-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Abide to the DataOfferCreationRequest.PolicyEnum rule #1055
Merged
ununhexium
merged 7 commits into
main
from
1587-create-data-offer-must-not-create-equivalents-of-the-always-true-policy
Oct 4, 2024
Merged
fix: Abide to the DataOfferCreationRequest.PolicyEnum rule #1055
ununhexium
merged 7 commits into
main
from
1587-create-data-offer-must-not-create-equivalents-of-the-always-true-policy
Oct 4, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kamilczaja
requested changes
Oct 2, 2024
...src/main/java/de/sovity/edc/ext/wrapper/api/ui/pages/data_offer/DataOfferPageApiService.java
Outdated
Show resolved
Hide resolved
...src/main/java/de/sovity/edc/ext/wrapper/api/ui/pages/data_offer/DataOfferPageApiService.java
Outdated
Show resolved
Hide resolved
I may be completely wrong but I don't think this works out |
…ith an empty (not null) policy definition
kamilczaja
approved these changes
Oct 2, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
ununhexium
deleted the
1587-create-data-offer-must-not-create-equivalents-of-the-always-true-policy
branch
October 4, 2024 08:13
ununhexium
added a commit
that referenced
this pull request
Oct 7, 2024
ununhexium
added a commit
that referenced
this pull request
Oct 7, 2024
* fix: Trivy TOOMANYREQUESTS GitHub API response by authenticating (#1053) * Trivy hotfix * fix: Abide to the DataOfferCreationRequest.PolicyEnum rule (#1055) * Enable CI on hotfix branches * select hotfix branch explicitly * change to target branch --------- Co-authored-by: Sebastian Opriel <22075788+SebastianOpriel@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/sovity/PMO-Software/issues/1587
Checklist