Unify date formats and fix of manually editing dates #809
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 0aaff2a.
illfixit
changed the title
richardtreier
requested changes
Sep 2, 2024
...itor/editor/policy-form-expression-constraint/policy-form-expression-constraint.component.ts
Outdated
Show resolved
Hide resolved
...y-editor/editor/recipes/timespan-restriction-dialog/timespan-restriction-dialog.component.ts
Outdated
Show resolved
Hide resolved
illfixit
deleted the
802-manually-editing-dates-shows-strange-behavior
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What issues does this PR close?
closes #802 Manually editing dates shows strange behavior
closes #803 Date format differs between pages
closes #810 Hover timespamps are 12h
Proper manual editing dates (802)
Create Policy
Result:
Timespan Restriction
both using calender
Intermediate step
Result
one date chosen via calender
second date inputted manually
intermediate step
Result
Similar date format across the app (803)
Assets Page (Dialog -> Signed)
Policies page
Catalog Browser (Dialog -> Temporal Coverage + Policy)
Contracts (Dialog -> Signed + Policy)
Hover timespamps are in 24h format now (810)
Contracts page
Transfer history page
Checklist