EX-2549 Address Jon's comments

sovrn · Dec 8, 2020 · 2b452a0 · 2b452a0
1 parent 20a3c53
commit 2b452a0
Showing 1 changed file with 3 additions and 4 deletions.
diff --git a/modules/sovrnBidAdapter.js b/modules/sovrnBidAdapter.js
@@ -30,7 +30,6 @@ export const spec = {
       let eids;
       let tpid = []
       let criteoId;
-      let imp;
 
       utils._each(bidReqs, function (bid) {
         if (!eids && bid.userId) {
@@ -54,7 +53,7 @@ export const spec = {
         bidSizes = ((utils.isArray(bidSizes) && utils.isArray(bidSizes[0])) ? bidSizes : [bidSizes])
         bidSizes = bidSizes.filter(size => utils.isArray(size))
         const processedSizes = bidSizes.map(size => ({w: parseInt(size[0], 10), h: parseInt(size[1], 10)}))
-        imp = {
+        const imp = {
           adunitcode: bid.adUnitCode,
           id: bid.bidId,
           banner: {
@@ -66,15 +65,15 @@ export const spec = {
           bidfloor: utils.getBidIdParameter('bidfloor', bid.params)
         }
 
-        sovrnImps.push(imp);
-
         const segmentsString = utils.getBidIdParameter('segments', bid.params)
 
         if (segmentsString) {
           imp.ext = {
             deals: segmentsString.split(',')
           }
         }
+
+        sovrnImps.push(imp);
       });
 
       const page = bidderRequest.refererInfo.referer