Skip to content

Commit

Permalink
Codefuel Bid Adapter: bugfixes and remove config import (prebid#7647)
Browse files Browse the repository at this point in the history
* * Update undertone adapter - change parameters - placementId parameter is now optional and not mandatory - undertoneBidAdapter.js

* Updated undertone bid adapter tests accordingly - undertoneBidAdapter_spec.js

* * Update undertone adapter - change parameters - placementId parameter is now optional and not mandatory - undertoneBidAdapter.js

 * Updated undertone bid adapter tests accordingly - undertoneBidAdapter_spec.js

* fix lint issue in undertone adapter spec

* added user sync function to undertone adapter

* * Update undertone adapter - change parameters - placementId parameter is now optional and not mandatory - undertoneBidAdapter.js

* Updated undertone bid adapter tests accordingly - undertoneBidAdapter_spec.js

* added user sync function to undertone adapter

* added user sync function to undertone adapter

* revert package-lock.json

* added user sync function to undertone adapter

* Update undertoneBidAdapter.js

* Update browsers.json

* bugfix bidderurl

* bugfix bidderurl

* bugfix bidderurl

* tests

Co-authored-by: omerko <omer.koren@perion.com>
Co-authored-by: Omer Koren <omerko@users.noreply.github.com>
Co-authored-by: AnnaPerion <annat@perion.com>
Co-authored-by: Oran Hollaender <oran@perion.com>
  • Loading branch information
5 people authored and Chris Pabst committed Jan 10, 2022
1 parent a68735f commit 9fc5102
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 7 deletions.
4 changes: 1 addition & 3 deletions modules/codefuelBidAdapter.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
import { deepAccess, isArray } from '../src/utils.js';
import { config } from '../src/config.js';
import {registerBidder} from '../src/adapters/bidderFactory.js';
import { BANNER } from '../src/mediaTypes.js';
const BIDDER_CODE = 'codefuel';
Expand Down Expand Up @@ -34,8 +33,7 @@ export const spec = {
const devicetype = getDeviceType()
const publisher = setOnAny(validBidRequests, 'params.publisher');
const cur = CURRENCY;
// const endpointUrl = 'http://localhost:5000/prebid'
const endpointUrl = config.getConfig('codefuel.bidderUrl');
const endpointUrl = 'https://ai-p-codefuel-ds-rtb-us-east-1-k8s.seccint.com/prebid'
const timeout = bidderRequest.timeout;

validBidRequests.forEach(bid => bid.netRevenue = 'net');
Expand Down
6 changes: 3 additions & 3 deletions modules/codefuelBidAdapter.md
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ You will receive the URLs when contacting us.
```
pbjs.setConfig({
codefuel: {
bidderUrl: 'https://ai-i-codefuel-ds-rtb-us-east-1-k8s-internal.seccint.com/prebid',
bidderUrl: 'https://ai-p-codefuel-ds-rtb-us-east-1-k8s.seccint.com/prebid',
usersyncUrl: 'https://usersync-url.com'
}
});
Expand Down Expand Up @@ -74,7 +74,7 @@ pbjs.setConfig({
pbjs.setConfig({
codefuel: {
bidderUrl: 'https://prebidtest.zemanta.com/api/bidder/prebidtest/bid/'
bidderUrl: 'https://ai-p-codefuel-ds-rtb-us-east-1-k8s.seccint.com/prebid'
}
});
```
Expand Down Expand Up @@ -105,7 +105,7 @@ pbjs.setConfig({
pbjs.setConfig({
codefuel: {
bidderUrl: 'https://prebidtest.zemanta.com/api/bidder/prebidtest/bid/'
bidderUrl: 'https://ai-p-codefuel-ds-rtb-us-east-1-k8s.seccint.com/prebid'
}
});
```
2 changes: 1 addition & 1 deletion test/spec/modules/codefuelBidAdapter_spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -183,7 +183,7 @@ describe('Codefuel Adapter', function () {
tmax: 500
}
const res = spec.buildRequests([bidRequest], commonBidderRequest)
expect(res.url).to.equal('https://bidder-url.com')
expect(res.url).to.equal('https://ai-p-codefuel-ds-rtb-us-east-1-k8s.seccint.com/prebid')
expect(res.data).to.deep.equal(expectedData)
})

Expand Down

0 comments on commit 9fc5102

Please sign in to comment.