Yieldmo Bid Adapter: add shared id support and cleaned up device.ip (p…

…rebid#7501) * sharedID support added * cleaned up device.ip support * utils import change
sovrn · Jan 10, 2022 · bcc92aa · bcc92aa
1 parent 0c8a5e4
commit bcc92aa
Show file tree

Hide file tree

Showing 2 changed files with 50 additions and 15 deletions.
diff --git a/modules/yieldmoBidAdapter.js b/modules/yieldmoBidAdapter.js
@@ -1,9 +1,10 @@
-import { getWindowTop, deepAccess, parseQueryStringParameters, isArrayOfNums, isArray, parseUrl, isEmpty, deepSetValue, isStr, isNumber, isInteger, isBoolean, logError } from '../src/utils.js';
+import { isNumber, isStr, isInteger, isBoolean, isArray, isEmpty, isArrayOfNums, getWindowTop, parseQueryStringParameters, parseUrl, deepSetValue, deepAccess, logError } from '../src/utils.js';
 import { BANNER, VIDEO } from '../src/mediaTypes.js';
 import { registerBidder } from '../src/adapters/bidderFactory.js';
 import { Renderer } from '../src/Renderer.js';
 import includes from 'core-js-pure/features/array/includes';
 import find from 'core-js-pure/features/array/find.js';
+import { createEidsArray } from './userId/eids.js';
 
 const BIDDER_CODE = 'yieldmo';
 const CURRENCY = 'USD';
@@ -46,8 +47,8 @@ export const spec = {
  buildRequests: function (bidRequests, bidderRequest) {
  const bannerBidRequests = bidRequests.filter(request => hasBannerMediaType(request));
  const videoBidRequests = bidRequests.filter(request => hasVideoMediaType(request));
-
  let serverRequests = [];
+ const eids = getEids(bidRequests[0]) || [];
  if (bannerBidRequests.length > 0) {
  let serverRequest = {
  pbav: '$prebid.version$',
@@ -99,6 +100,9 @@ export const spec = {
  });
  serverRequest.p = '[' + serverRequest.p.toString() + ']';
 
+ if (eids.length) {
+ serverRequest.eids = JSON.stringify(eids);
+ };
  // check if url exceeded max length
  const url = `${BANNER_SERVER_ENDPOINT}?${parseQueryStringParameters(serverRequest)}`;
  let extraCharacters = url.length - MAX_BANNER_REQUEST_URL_LENGTH;
@@ -121,6 +125,9 @@ export const spec = {
 
  if (videoBidRequests.length > 0) {
  const serverRequest = openRtbRequest(videoBidRequests, bidderRequest);
+ if (eids.length) {
+ serverRequest.user = { eids };
+ };
  serverRequests.push({
  method: 'POST',
  url: VIDEO_SERVER_ENDPOINT,
@@ -447,14 +454,10 @@ function openRtbSite(bidRequest, bidderRequest) {
  * @return Object OpenRTB's 'device' object
  */
 function openRtbDevice(bidRequest) {
- const ip = deepAccess(bidRequest, 'params.device.ip');
  const deviceObj = {
  ua: navigator.userAgent,
  language: (navigator.language || navigator.browserLanguage || navigator.userLanguage || navigator.systemLanguage),
  };
- if (ip) {
- deviceObj.ip = ip;
- }
  return deviceObj;
 }
 
@@ -595,3 +598,14 @@ function shortcutProperty(extraCharacters, target, propertyName) {
 
  return charactersLeft;
 }
+
+/**
+ * Creates and returnes eids arr using createEidsArray from './userId/eids.js' module;
+ * @param {Object} openRtbRequest OpenRTB's request as a cource of userId.
+ * @return array of eids objects
+ */
+function getEids(bidRequest) {
+ if (deepAccess(bidRequest, 'userId')) {
+ return createEidsArray(bidRequest.userId) || [];
+ }
+};
diff --git a/test/spec/modules/yieldmoBidAdapter_spec.js b/test/spec/modules/yieldmoBidAdapter_spec.js
@@ -307,7 +307,7 @@ describe('YieldmoAdapter', function () {
  });
 
  it('should only shortcut properties rather then completely remove it', () => {
- const longString = new Array(7516).join('a');
+ const longString = new Array(8000).join('a');
  const localWindow = utils.getWindowTop();
 
  const originalTitle = localWindow.document.title;
@@ -319,7 +319,7 @@ describe('YieldmoAdapter', function () {
  refererInfo: {
  numIframes: 1,
  reachedTop: true,
- referer: longString,
+ title: longString,
  },
  })
  )[0];
@@ -345,6 +345,20 @@ describe('YieldmoAdapter', function () {
  let placementInfo = buildAndGetPlacementInfo(bidArray);
  expect(placementInfo).to.include('"gpid":"/6355419/Travel/Europe/France/Paris"');
  });
+
+ it('should add eids to the banner bid request', function () {
+ const params = {
+ userId: {pubcid: 'fake_pubcid'},
+ fakeUserIdAsEids: [{
+ source: 'pubcid.org',
+ uids: [{
+ id: 'fake_pubcid',
+ atype: 1
+ }]
+ }]
+ };
+ expect(buildAndGetData([mockBannerBid({...params})]).eids).equal(JSON.stringify(params.fakeUserIdAsEids));
+ });
  });
 
  describe('Instream video:', function () {
@@ -469,19 +483,26 @@ describe('YieldmoAdapter', function () {
  expect(buildAndGetData([mockVideoBid({schain})]).schain).to.deep.equal(schain);
  });
 
- it('should add ip to the video bidRequest', () => {
- const device = {
- ip: '111.222.333.444'
- };
- expect(buildAndGetData([mockVideoBid(null, {device})]).device.ip).to.be.equal(device.ip);
- });
-
  it('should add gpid to the video request', function () {
  const ortb2Imp = {
  ext: { data: { pbadslot: '/6355419/Travel/Europe/France/Paris' } },
  };
  expect(buildAndGetData([mockVideoBid({ortb2Imp})]).imp[0].ext.gpid).to.be.equal(ortb2Imp.ext.data.pbadslot);
  });
+
+ it('should add eids to the video bid request', function () {
+ const params = {
+ userId: {pubcid: 'fake_pubcid'},
+ fakeUserIdAsEids: [{
+ source: 'pubcid.org',
+ uids: [{
+ id: 'fake_pubcid',
+ atype: 1
+ }]
+ }]
+ };
+ expect(buildAndGetData([mockVideoBid({...params})]).user.eids).to.eql(params.fakeUserIdAsEids);
+ });
  });
  });