Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added tdid and ad-unit-code #23

Closed
wants to merge 23 commits into from
Closed

added tdid and ad-unit-code #23

wants to merge 23 commits into from

Commits on Jun 16, 2020

  1. added tdid and ad-unit-code

    John Rosendahl committed Jun 16, 2020
    Configuration menu
    Copy the full SHA
    3f6c9be View commit details
    Browse the repository at this point in the history
  2. fixed tdid

    John Rosendahl committed Jun 16, 2020
    Configuration menu
    Copy the full SHA
    06ed63b View commit details
    Browse the repository at this point in the history

Commits on Jun 17, 2020

  1. merged master

    John Rosendahl committed Jun 17, 2020
    Configuration menu
    Copy the full SHA
    27654f1 View commit details
    Browse the repository at this point in the history

Commits on Jun 18, 2020

  1. PubMatic bid adapter to support price floors module (prebid#5387)

    * added support for pubcommon, digitrust, id5id
    
    * added support for IdentityLink
    
    * changed the source for id5
    
    * added unit test cases
    
    * changed source param for identityLink
    
    * added support for floors module
    
    * using floorModule to set floor
    
    * removed commented console.log statements
    pm-harshad-mane authored Jun 18, 2020
    Configuration menu
    Copy the full SHA
    5ac08c6 View commit details
    Browse the repository at this point in the history
  2. Triplelift Adaptor: Use Floors Module (prebid#5329)

    * access floor from floors module
    
    * int -> float and null check
    
    * let -> const
    colbertk authored Jun 18, 2020
    Configuration menu
    Copy the full SHA
    9b4def5 View commit details
    Browse the repository at this point in the history
  3. removed digitrust

    John Rosendahl committed Jun 18, 2020
    Configuration menu
    Copy the full SHA
    7421370 View commit details
    Browse the repository at this point in the history

Commits on Jun 19, 2020

  1. appnexusBidAdapter - fix video params (prebid#5394)

    * appnexusBidAdapter - fix video params
    
    * remove mimes field
    jsnellbaker authored Jun 19, 2020
    Configuration menu
    Copy the full SHA
    a394bc6 View commit details
    Browse the repository at this point in the history
  2. PubMatic adds support for bidUserIdAsEids (prebid#5397)

    * added support for pubcommon, digitrust, id5id
    
    * added support for IdentityLink
    
    * changed the source for id5
    
    * added unit test cases
    
    * changed source param for identityLink
    
    * id value should be string only
    
    * id value should be string; changed test data
    
    * pubmatic using userIdAsEids
    
    commented unnecessary code
    PubMatic will no longer read Digitrust from config or independent library setup
    PubMatic will no loner read TTDID from config or independent library setup
    
    * chnages in test cases for userIdAsEids
    
    commented unnecessary test cases
    PubMatic will no longer read Digitrust from config or independent library setup
    PubMatic will no loner read TTDID from config or independent library setup
    
    * deleted commented code and test cases
    
    * deleted a commented line
    
    * lint effect
    pm-harshad-mane authored Jun 19, 2020
    Configuration menu
    Copy the full SHA
    aa877b2 View commit details
    Browse the repository at this point in the history
  3. repush

    jrosendahl committed Jun 19, 2020
    Configuration menu
    Copy the full SHA
    cab6058 View commit details
    Browse the repository at this point in the history

Commits on Jun 22, 2020

  1. External ids (prebid#5351)

    * externalIds (SIM-657) Added external ids and associated unit test.
    
    * externalIds - Added DEFAULT_PARAMS_WITH_EIDS that contains the external id information for the unit test
    
    * externalIds (SIM-657) uses createEidsArray found in the eid.js
    
    * externalIds cleanup spaces and tabs, adding a missing import for createEids in eids.js
    
    * externalIds adding a space where it is needed to fix a wonderful test.
    lowendavid authored Jun 22, 2020
    Configuration menu
    Copy the full SHA
    4e59331 View commit details
    Browse the repository at this point in the history
  2. 33Across: CCPA Compliance + Schain support (prebid#5365)

    * check gdpr in buildRequest
    
    * User sync based on whether gdpr applies or not
    
    * check if consent data exists during user sync
    
    * split user sync into further branches: 1) when gdpr does not apply 2) when consent data is unavailable
    
    * contribute viewability to ttxRequest
    
    * update tests
    
    * remove window mock from tests
    
    * use local variables
    
    * introduce ServerRequestBuilder
    
    * add withOptions() method to ServerRequestBuilder
    
    * add semicolons
    
    * sync up package-lock.json with upstream/master
    
    * stub window.top in tests
    
    * introduce getTopWindowSize() for test purpose
    
    * reformat code
    
    * add withSite() method to TtxRequestBuilder
    
    add withSite() method to TtxRequestBuilder
    
    * add isIframe() and _isViewabilityMeasurable()
    
    * handle NON_MEASURABLE viewability in nested iframes
    
    * consider page visibility, stub utils functions getWindowTop() and getWindowSelf()
    
    * contribute viewability as 0 for inactive tab
    
    * add prebidjs version to ttx request
    
    * send caller as an array
    
    * fix JSDoc in utils.js
    
    * send viewability as non measurable when unable to locate target HTMLElement, add warning message
    
    * introduce mapAdSlotPathToElementId()
    
    * introduce getAdSlotHTMLElement(), add logging
    
    * introduce mapAdSlotPathToElementId()
    
    * update logging in ad unit path to element id mapping
    
    * rephrase logging, fix tests
    
    * update adapter documentation
    
    * remove excessive logging
    
    * improve logging
    
    * revert change
    
    * fix return of _mapAdUnitPathToElementId()
    
    * improve logging of _mapAdUnitPathToElementId()
    
    * do not use Array.find()
    
    * return id once element is found
    
    * return id once element is found
    
    * let -> const
    
    * Removing killswitch behavior for GDPR
    
    * Updated comments to reflect current gdpr logic
    
    * URI encode consent string
    
    * Updated example site ID to help Prebid team e2e test our adapter
    
    * send page url in ortb
    
    * Removed redundant pageUrl default
    
    * Restored package-log.json that mirrors prebid's repo
    
    * Sending USP string during buildRequest
    
    * Adding USP consent data to user sync
    
    * add unit test for syncing without bidrequest
    
    * Changed to uspConsent to make the connatation consistent
    
    * Resetting adapter state in adapter after user sync rather than exposing it.
    
    * removed console log
    
    * Adding schain info
    
    * remove setting empty format ext
    
    * better tests invalid values
    
    * removing validation of schain
    
    * Fixed lint errors
    
    Co-authored-by: Gleb Glushtsov <gleb.glushtsov@33across.com>
    Co-authored-by: Gleb Glushtsov <glebglushtsov@users.noreply.github.com>
    Co-authored-by: Gleb Glushtsov <gleb.glushtsov@gmail.com>
    Co-authored-by: Aparna Hegde <ahegde@pool-10-1-150-29-nyc.internal.33across.com>
    Co-authored-by: Aparna Hegde <ahegde@admins-MacBook-Pro.local>
    Co-authored-by: Aparna Hegde <ahegde@pool-10-1-150-137-nyc.internal.33across.com>
    Co-authored-by: Aparna Hegde <ahegde@pool-10-1-150-96-nyc.internal.33across.com>
    Co-authored-by: Aparna Hegde <ahegde@AHEGDE-MAC.local>
    Co-authored-by: Aparna Hegde <ahegde@AHEGDE-MAC.fios-router.home>
    10 people authored Jun 22, 2020
    Configuration menu
    Copy the full SHA
    57f8beb View commit details
    Browse the repository at this point in the history
  3. added waardex adapter (prebid#5349)

    * added waardex adapter
    
    * removed support http from adapter
    
    Co-authored-by: Max Shuhaliia <mshuhaliia@Maxs-MacBook-Pro-2.local>
    mshuhaliia and Max Shuhaliia authored Jun 22, 2020
    Configuration menu
    Copy the full SHA
    ba6d904 View commit details
    Browse the repository at this point in the history
  4. Add customParams to yieldlab configuration (prebid#5374)

    Customers are using custom parameters to our endpoint to use them downstream. We need a way of supporting this in prebid.
    mirkorean authored Jun 22, 2020
    Configuration menu
    Copy the full SHA
    cc845b0 View commit details
    Browse the repository at this point in the history

Commits on Jun 23, 2020

  1. Vidazoo Adapter: Feature/user-id (prebid#5386)

    * feat(module): multi size request
    
    * fix getUserSyncs
    added tests
    
    * update(module): package-lock.json from master
    
    * feat(client): add user id request support
    
    * fix(client): lint errors
    
    Co-authored-by: roman <shmoop207@gmail.com>
    uditalias and shmoop207 authored Jun 23, 2020
    Configuration menu
    Copy the full SHA
    263c6cc View commit details
    Browse the repository at this point in the history
  2. LiveIntentId submodule updates (prebid#5407)

    * LiveIntentId submodule.
    
    Bumped the live-connect-js version with changes:
    - fixed the problem where userId/index.js was sending the full config on `decode`, while the docs claim it should only send `.params`
    - removed the uuid lib
    - removed the support for legacy LI first party cookies
    - removed the redundant config parameter `providedIdentifierName`
    - support for running live-connect inside of multiple wrappers
    
    * LiveIntentId submodule.
    
    Removed reading of non-accessible and therefore redundant code snippets
    
    * Removed excessive config logging.
    
    * Making the publisher id parameter optional.
    
    * Removed unneeded check.
    jankoulaga authored Jun 23, 2020
    Configuration menu
    Copy the full SHA
    d9d7c0c View commit details
    Browse the repository at this point in the history
  3. 33Across: Adding floors support (prebid#5408)

    * check gdpr in buildRequest
    
    * User sync based on whether gdpr applies or not
    
    * check if consent data exists during user sync
    
    * split user sync into further branches: 1) when gdpr does not apply 2) when consent data is unavailable
    
    * contribute viewability to ttxRequest
    
    * update tests
    
    * remove window mock from tests
    
    * use local variables
    
    * introduce ServerRequestBuilder
    
    * add withOptions() method to ServerRequestBuilder
    
    * add semicolons
    
    * sync up package-lock.json with upstream/master
    
    * stub window.top in tests
    
    * introduce getTopWindowSize() for test purpose
    
    * reformat code
    
    * add withSite() method to TtxRequestBuilder
    
    add withSite() method to TtxRequestBuilder
    
    * add isIframe() and _isViewabilityMeasurable()
    
    * handle NON_MEASURABLE viewability in nested iframes
    
    * consider page visibility, stub utils functions getWindowTop() and getWindowSelf()
    
    * contribute viewability as 0 for inactive tab
    
    * add prebidjs version to ttx request
    
    * send caller as an array
    
    * fix JSDoc in utils.js
    
    * send viewability as non measurable when unable to locate target HTMLElement, add warning message
    
    * introduce mapAdSlotPathToElementId()
    
    * introduce getAdSlotHTMLElement(), add logging
    
    * introduce mapAdSlotPathToElementId()
    
    * update logging in ad unit path to element id mapping
    
    * rephrase logging, fix tests
    
    * update adapter documentation
    
    * remove excessive logging
    
    * improve logging
    
    * revert change
    
    * fix return of _mapAdUnitPathToElementId()
    
    * improve logging of _mapAdUnitPathToElementId()
    
    * do not use Array.find()
    
    * return id once element is found
    
    * return id once element is found
    
    * let -> const
    
    * Removing killswitch behavior for GDPR
    
    * Updated comments to reflect current gdpr logic
    
    * URI encode consent string
    
    * Updated example site ID to help Prebid team e2e test our adapter
    
    * send page url in ortb
    
    * Removed redundant pageUrl default
    
    * Restored package-log.json that mirrors prebid's repo
    
    * Sending USP string during buildRequest
    
    * Adding USP consent data to user sync
    
    * add unit test for syncing without bidrequest
    
    * Changed to uspConsent to make the connatation consistent
    
    * Resetting adapter state in adapter after user sync rather than exposing it.
    
    * removed console log
    
    * Adding schain info
    
    * remove setting empty format ext
    
    * better tests invalid values
    
    * removing validation of schain
    
    * Fixed lint errors
    
    * First cut for bidfloors support
    
    * fixed where getFloors is read
    
    * fixed merge conflicts
    
    Co-authored-by: Gleb Glushtsov <gleb.glushtsov@33across.com>
    Co-authored-by: Gleb Glushtsov <glebglushtsov@users.noreply.github.com>
    Co-authored-by: Gleb Glushtsov <gleb.glushtsov@gmail.com>
    Co-authored-by: Aparna Hegde <ahegde@pool-10-1-150-29-nyc.internal.33across.com>
    Co-authored-by: Aparna Hegde <ahegde@admins-MacBook-Pro.local>
    Co-authored-by: Aparna Hegde <ahegde@pool-10-1-150-137-nyc.internal.33across.com>
    Co-authored-by: Aparna Hegde <ahegde@pool-10-1-150-96-nyc.internal.33across.com>
    Co-authored-by: Aparna Hegde <ahegde@AHEGDE-MAC.local>
    Co-authored-by: Aparna Hegde <ahegde@AHEGDE-MAC.fios-router.home>
    10 people authored Jun 23, 2020
    Configuration menu
    Copy the full SHA
    18d1e10 View commit details
    Browse the repository at this point in the history
  4. Vidazoo Adapter: Feature/screen-size (prebid#5385)

    * feat(module): multi size request
    
    * fix getUserSyncs
    added tests
    
    * update(module): package-lock.json from master
    
    * feat(client): add screen resolution as request param
    
    * feat(client): add `res` param to spec
    
    * fix(client): screen size inside test
    
    Co-authored-by: roman <shmoop207@gmail.com>
    uditalias and shmoop207 authored Jun 23, 2020
    Configuration menu
    Copy the full SHA
    9c47806 View commit details
    Browse the repository at this point in the history
  5. Appier: add support for aliases (prebid#5392)

    * Add initial partial implementation for Appier bidder adapter.
    
    * Use relative protocol for bidder API url.
    
    * Handle server response for Appier adapter and add related unit tests.
    
    * Support farm-specific prebid server and allow overriding the server with setConfig().
    
    * Add doc for Appier bid adapter.
    
    * Fix const correctness.
    
    * Append requestId to the beacon image URL of Appier adapter to reduce the risks of being cached by proxy servers or browsers.
    
    * Send bidderRequest.refererInfo to Appier bidder server.
    
    * Remove the show beacon since now we generate it in the backend server.
    
    * Only generate a show beacon url if it's not provided by the backend.
    
    * Add version information for Appier adapter using semver (starts from 1.0.0).
    
    * Add a new adapter for Appier bidder.
    
    * Add a new adapter for Appier bidder.
    
    * add appier analyticsAdapter skeleton.
    
    * update initial working version.
    
    * refactor and remove debug messages.
    
    * fix config checking logic.
    
    * implement bidAdjustment and add timeout before send event.
    
    * unify cache operation into cacheManager to avoid direct key/value operation.
    
    * Update server name.
    
    * correct currency impl and message payload. remove unused debug messages.
    
    * update var naming.
    
    * rename creative vars. cleanup comments.
    
    * add test cases for AnalyticsAdapter.
    
    * update test specs file.
    
    * remove spec from main branch.
    
    * add unit tests for AnalyticsAdapter, #1 - Happy cases.
    
    * refactor tests.
    
    * update unit tests for AnalyticsAdapter.
    
    * add tests for bid-adjusted, bid-timeout events
    
    * fix bid adjustment test case.
    
    * add nobid case in analytics unit test.
    
    * add test case for delayed bids and prebidWon messages.
    
    * Use logInfo and logError utilility functions instead of console.log() to print debug messages.
    
    * handle timeout status message correctly.
    
    * correct isTimeout setting logic and test cases.
    
    * replace for...of by array.forEach for IE11
    
    * apply auto formatter.
    
    * refactor: extract timeout logic to a helper function
    
    * tag analytic version with 0.1.0-beta for iCook release
    
    * Re-implement the appier analytics adapter with a simpler design and correctly handle timeouts.
    
    * Remove unused variables.
    
    * Rename methods to improve consistency.
    
    * Code cleanup: rename methods and avoid duplicated code.
    
    * Fix wrong bid response data caused by non-deterministic event ordering of prebid.js.
    
    * Send bid message immediately on auction end without delay.
    
    * add withCredentials in ajax call to get client cookie.
    
    * Fix broken unit test for appier analytic adapter.
    
    * add prediction id support.
    
    * update predictionId/configId format in tests.
    
    * Init refined appier analytics testing
    
    * hotfix: appier analytics support browserstack bug
    
    * feat: add aliases
    
    Co-authored-by: Hong Jen-Yee (PCMan) <pcman.hong@appier.com>
    Co-authored-by: Yuan-Hung Huang <yuanhung.huang@appier.com>
    Co-authored-by: kdchang <kd.chang@appier.com>
    Co-authored-by: chih-ping-weng <chihping.weng@appier.com>
    5 people authored Jun 23, 2020
    Configuration menu
    Copy the full SHA
    6cfe4cc View commit details
    Browse the repository at this point in the history

Commits on Jun 24, 2020

  1. Add GMOSSP Adapter (prebid#5377)

    * Add GMOSSP Adapter
    
    * fix test param
    arasaki-yuki authored Jun 24, 2020
    Configuration menu
    Copy the full SHA
    3857643 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    cf33ada View commit details
    Browse the repository at this point in the history
  3. Delete package-lock.json

    jrosendahl authored Jun 24, 2020
    Configuration menu
    Copy the full SHA
    ca2f896 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    72a4d7a View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    09a92ba View commit details
    Browse the repository at this point in the history