Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added an option to set default view type per directory #1519

Open
wants to merge 1 commit into
base: alpha
Choose a base branch
from
Open

added an option to set default view type per directory #1519

wants to merge 1 commit into from

Conversation

M4hd1BD
Copy link
Contributor

@M4hd1BD M4hd1BD commented Jun 22, 2023

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Security fix
  • Improvement
  • New Feature
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Text changes
  • Other... Please describe:

Description

How to reproduce the issue or how to test the changes

  1. Go to Directory Builder > All Listings Layout > Settings
  2. Set a view type
  3. Now this should be respected regardless of what is set on Settings > All Listings
  4. However, what it won't respect is what is set on the shortcode, shortcode one will get preference.

Any linked issues

Fixes #

Checklist

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@syedgalib syedgalib Awaiting requested review from syedgalib syedgalib is a code owner

@vairafiq vairafiq Awaiting requested review from vairafiq vairafiq is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@M4hd1BD