Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecated function #1637

Merged
merged 3 commits into from
Nov 2, 2023
Merged

Deprecated function #1637

merged 3 commits into from
Nov 2, 2023

Conversation

Armanul46
Copy link
Collaborator

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Security fix
  • Improvement
  • New Feature
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Text changes
  • Other... Please describe:

Description

How to reproduce the issue or how to test the changes

  1. Deprecated atbdp_parse_videos method from Directorist_Base class
  2. Use ecs_url on single listing video field

Any linked issues

Fixes #

Checklist

@Armanul46 Armanul46 requested a review from vairafiq as a code owner November 2, 2023 04:18
obiPlabon
obiPlabon approved these changes Nov 2, 2023
View reviewed changes
Copy link
Collaborator

@obiPlabon obiPlabon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@obiPlabon obiPlabon merged commit f86e909 into sovware:alpha Nov 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@obiPlabon obiPlabon obiPlabon approved these changes

@vairafiq vairafiq Awaiting requested review from vairafiq vairafiq is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Armanul46 @obiPlabon