Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix guest review conflict with core comment setting #1650

Conversation

obiPlabon
Copy link
Collaborator

PR Type

What kind of change does this PR introduce?

  • Bugfix

Description

When the following setting is enabled guests cannot share reviews. Login required notice is shown to users.
Settings > Discussion > Users must be registered and logged in to comment

Any linked issues

There's a custom support for this issue.

Checklist

obiPlabon added 30 commits July 27, 2022 22:56
@obiPlabon obiPlabon requested a review from vairafiq as a code owner November 9, 2023 09:28
Copy link
Member

@vairafiq vairafiq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@vairafiq vairafiq merged commit ff8d5aa into sovware:alpha Nov 11, 2023
@obiPlabon obiPlabon deleted the fix-guest-review-conflict-with-core-comment-setting branch November 16, 2023 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants