Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix extension install and preview issue #1749

Merged
merged 2 commits into from
May 22, 2024
Merged

fix extension install and preview issue #1749

merged 2 commits into from
May 22, 2024

Conversation

vairafiq
Copy link
Member

@vairafiq vairafiq commented May 20, 2024 •
edited
Loading

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Security fix
  • Improvement
  • New Feature
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Text changes
  • Other... Please describe:

Description

How to reproduce the issue or how to test the changes

  • Go to the extension menu and login with your directionst.com credentials
  • Check the available in your subscription tab and see some of the extensions without descriptions and thumbnail image

Any linked issues

Fixes #

Checklist

@vairafiq vairafiq requested a review from syedgalib as a code owner May 20, 2024 05:40
obiPlabon
obiPlabon approved these changes May 22, 2024
View reviewed changes
Copy link
Collaborator

@obiPlabon obiPlabon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@obiPlabon obiPlabon merged commit 49a2b68 into alpha May 22, 2024
@obiPlabon obiPlabon deleted the fix/extension-issue branch May 22, 2024 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@obiPlabon obiPlabon obiPlabon approved these changes

@syedgalib syedgalib Awaiting requested review from syedgalib syedgalib is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vairafiq @obiPlabon