Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rewrite the check of uninstall.php #1781

Merged
merged 2 commits into from
Aug 26, 2024
Merged

Conversation

HeyMehedi
Copy link
Collaborator

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Security fix
  • Improvement
  • New Feature
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Text changes
  • Other... Please describe:

Checklist

@HeyMehedi HeyMehedi requested a review from vairafiq as a code owner July 7, 2024 06:44
@vairafiq vairafiq added this to the v7.11.1 milestone Aug 18, 2024
uninstall.php Outdated
@@ -101,11 +96,20 @@ function directorist_uninstall() {

foreach ($sites as $site) {
switch_to_blog($site->blog_id);

if( ! get_directorist_option('enable_uninstall',0) ) {
return;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

user continue not return

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the review, it's changed.

Copy link
Member

@vairafiq vairafiq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@vairafiq vairafiq merged commit 97529a3 into sovware:alpha Aug 26, 2024
@HeyMehedi HeyMehedi deleted the uninstall branch November 14, 2024 07:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants