Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement/templetiq #1810

Merged
merged 4 commits into from
Aug 21, 2024
Merged

Implement/templetiq #1810

merged 4 commits into from
Aug 21, 2024

Conversation

vairafiq
Copy link
Member

@vairafiq vairafiq commented Aug 20, 2024

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Security fix
  • Improvement
  • New Feature
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Text changes
  • Other... Please describe:

Description

How to reproduce the issue or how to test the changes

https://www.loom.com/share/d76536e704cd4f8d928e4a9d63d84b9f

Any linked issues

Fixes #

Checklist

@vairafiq vairafiq requested a review from syedgalib as a code owner August 20, 2024 04:11
@obiPlabon
Copy link
Collaborator

  1. Inaccurate directory count.
image image image
  1. Edit link on private and published tab doesn't work.

  2. Private tab directories has the Make default option. I think this option should be available only for published.

image
  1. Improve texts
image -> Either change the "Create New Directory Type" button label to "Add New Directory Type" or change the model heading to "Create New Directory Type". By the way "create" is always new and I think "Add New Directory Type" is more appropriate in WordPress's context, as WP already uses terms like Add New Post, Add New Page etc.

-> Improve: "You can select a template to assist you, or start from scratch.". Maybe "Start from scratch or select a template to save time"

-> Improve: "Choose a directory template" to "Select a directory template" (please do not use different terms for the same task and purpose, be consistent)

-> *** We should take user consent before installing the Templatiq plugin and there should be a clear message about what it is and where we are downloading from, transparency matters.

], 200);
}

if ( ! current_user_can( 'manage_options' ) ) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Collaborator

@obiPlabon obiPlabon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shared.

Copy link
Collaborator

@obiPlabon obiPlabon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@obiPlabon obiPlabon merged commit 842c7b4 into v8-beta Aug 21, 2024
@obiPlabon obiPlabon deleted the implement/templetiq branch August 21, 2024 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants