New settings #1819
Merged
New settings #1819
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vairafiq
reviewed
Aug 29, 2024
| ], | ||
| ], | ||
| 'expired_listings_actions' => [ | ||
| 'title' => __( 'Expired Listings Actions', 'directorist' ), |
There was a problem hiding this comment.
label should be Expired Listings Management
| 'fields' => [ | ||
| // 'all_listing_layout', | ||
| 'enable_multi_directory', | ||
| 'can_renew_listing', 'email_to_expire_day', 'email_renewal_day', 'delete_expired_listing', 'delete_expired_listings_after', 'deletion_mode', 'paginate_author_listings', 'display_author_email', 'author_cat_filter', 'guest_listings', 'lazy_load_taxonomy_fields' |
There was a problem hiding this comment.
Some code is still there https://prnt.sc/CFWGYvzfS9_w
| 'fields' => [ | ||
| // 'all_listing_layout', | ||
| 'enable_multi_directory', | ||
| 'can_renew_listing', 'email_to_expire_day', 'email_renewal_day', 'delete_expired_listing', 'delete_expired_listings_after', 'deletion_mode', 'paginate_author_listings', 'display_author_email', 'author_cat_filter', 'guest_listings', 'lazy_load_taxonomy_fields' |
There was a problem hiding this comment.
Need to remove https://prnt.sc/JOD21vMT8Loo
| @@ -4706,7 +4522,7 @@ public function prepare_settings() | |||
| 'sections' => apply_filters( 'atbdp_listing_settings_listings_page_sections', [ | |||
| 'labels' => [ | |||
| 'fields' => [ | |||
| 'display_listings_header', 'all_listing_title', 'listing_instant_search', 'listing_filters_button', 'listing_filters_icon', 'listings_filter_button_text', 'listing_default_radius_distance', 'listings_filters_button', 'listings_reset_text', 'listings_apply_text', 'display_sort_by', 'sort_by_text', 'listings_sort_by_items', 'display_view_as', 'view_as_text', 'listings_view_as_items', 'default_listing_view', 'grid_view_as', 'all_listing_columns', 'order_listing_by', 'sort_listing_by', 'preview_image_quality', 'way_to_show_preview', 'crop_width', 'crop_height', 'prv_container_size_by', 'prv_background_type', 'prv_background_color', 'default_preview_image', 'info_display_in_single_line', 'address_location', 'paginate_all_listings', 'all_listing_page_items' | |||
There was a problem hiding this comment.
Need to remove from usage and default JSON https://prnt.sc/y5UVU1TNie0Y
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
What kind of change does this PR introduce?
Description
How to reproduce the issue or how to test the changes
Any linked issues
Fixes #
Checklist