Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can the proc macro generate messages recursively? #122

Open
sowbug opened this issue Mar 31, 2023 · 0 comments
Open

Can the proc macro generate messages recursively? #122

sowbug opened this issue Mar 31, 2023 · 0 comments
Labels
design Issues that need to be resolved in the design
Milestone

Comments

@sowbug
Copy link
Owner

sowbug commented Mar 31, 2023

If we embed one Nano type inside another, the desired outcome would be an enum whose type is that embedded Nano type. And so on. This is preferable to flattening the struct. It could also allow a variable number of complex parts in an instrument, like an N-operator FM synth.

@sowbug sowbug added the design Issues that need to be resolved in the design label Mar 31, 2023
@sowbug sowbug added this to the Icebox milestone Mar 31, 2023
sowbug added a commit that referenced this issue Apr 2, 2023

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
As we make progress toward #122, we need the ability to specify
certain #[nano] fields that can be handled by update(), but aren't
expected to respond to F32ControlValue. An example is EnvelopeParams,
which could be flattened into ADSR, but is better as a serializable
thing that isn't a controllable thing. This meant teaching #[nano]
that some fields should populate the Nano params struct, and
should be handled in update(), but should not appear in the
automation GUI or respond to F32ControlValue (which makes no
sense <EnvelopeParams>::into()).

- Taught #[nano] to be smarter
- Moved ToySynth -> DebugSynth, and created a more standard ToySynth
- Moved all the proc-macro tests from struct-sync into the orchestration
  crate, so that they'll be tracked with this repo and tested.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design Issues that need to be resolved in the design
Projects
None yet
Development

No branches or pull requests

1 participant