Skip to content

Commit

Permalink
Use primer class to set height to full
Browse files Browse the repository at this point in the history
  • Loading branch information
Matthew Burnett committed Mar 6, 2019
1 parent be9dda4 commit 4e500ca
Show file tree
Hide file tree
Showing 5 changed files with 5 additions and 11 deletions.
4 changes: 2 additions & 2 deletions _includes/header.html
Original file line number Diff line number Diff line change
Expand Up @@ -17,12 +17,12 @@
{% endif %}

<!doctype html>
<html>
<html class="height-full">
<head>
<meta charset="utf-8">
<meta name="description" content="{{ meta_description }}" />
<title>{{ user.name }}</title>
<meta name="viewport" content="width=device-width, initial-scale=1, shrink-to-fit=no">
<link href="{{ "/assets/styles.css" | absolute_url }}" rel="stylesheet" type="text/css">
</head>
<body class="bg-white" {% if site.style == 'dark' %}style="background-color: #2f363d !important"{% endif %}>
<body class="bg-white height-full" {% if site.style == 'dark' %}style="background-color: #2f363d !important"{% endif %}>
2 changes: 1 addition & 1 deletion _layouts/default.html
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ <h1 class="f00-light lh-condensed mb-5">{{ page.title }}</h1>
</div>
</div>
{% else %}
<div class="d-md-flex {% unless site.style == 'dark' %}border-md-bottom{% endunless %}">
<div class="d-md-flex height-full {% unless site.style == 'dark' %}border-md-bottom{% endunless %}">
<div class="flex-self-stretch {% if site.style == 'dark' %}bg-gray-dark{% else %}border-md-right border-gray-light bg-white{% endif %} col-md-5 col-lg-4 col-xl-3 px-4 px-md-6 px-lg-7 py-6">
{% include masthead.html metadata=true %}
</div>
Expand Down
2 changes: 1 addition & 1 deletion _layouts/home.html
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
{% endunless %}
</div>
{% else %}
<div class="d-md-flex {% unless site.style == 'dark' %}border-md-bottom{% endunless %}">
<div class="d-md-flex height-full {% unless site.style == 'dark' %}border-md-bottom{% endunless %}">
<div class="flex-self-stretch {% if site.style == 'dark' %}bg-gray-dark{% else %}border-md-right border-gray-light bg-white{% endif %} col-md-5 col-lg-4 col-xl-3 px-4 px-md-6 px-lg-7 py-6">
{% include masthead.html metadata=true %}
</div>
Expand Down
2 changes: 1 addition & 1 deletion _layouts/post.html
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ <h1 class="f00-light lh-condensed">{{ page.title }}</h1>
</div>
</div>
{% else %}
<div class="d-md-flex {% unless site.style == 'dark' %}border-md-bottom{% endunless %}">
<div class="d-md-flex height-full {% unless site.style == 'dark' %}border-md-bottom{% endunless %}">
<div class="flex-self-stretch {% if site.style == 'dark' %}bg-gray-dark{% else %}border-md-right border-gray-light bg-white{% endif %} col-md-5 col-lg-4 col-xl-3 px-4 px-md-6 px-lg-7 py-6">
{% include masthead.html metadata=true %}
</div>
Expand Down
6 changes: 0 additions & 6 deletions assets/styles.scss
Original file line number Diff line number Diff line change
Expand Up @@ -28,9 +28,3 @@ body {
margin-bottom: 16px;
}
}

body,
html,
.d-md-flex {
height: 100%;
}

0 comments on commit 4e500ca

Please sign in to comment.