Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proper Embroider Support #174

Closed
wants to merge 4 commits into from
Closed

Conversation

NullVoxPopuli
Copy link
Collaborator

@NullVoxPopuli NullVoxPopuli commented May 10, 2024

This will cause a change in documentation as it'll be far more stable (and also our way of fixing some embroider compatibility problems due to messing with the wire format).

Breaking changes:

  • we no longer use the appJsUnplugin in embroider
  • no longer supported:
    • ember-template-imports earlier than v4
    • babel-plugin-ember-template-compilation earlier than 2.2.5
    • rollup-plugin-glimmer-template-tag

NullVoxPopuli added a commit that referenced this pull request May 16, 2024
NullVoxPopuli added a commit that referenced this pull request May 16, 2024
* Refactor path utils

* More refactors pulled over from #174

* womp

* debug

* debug

* debug

* debug

* debug

* debug

* handle the embroider-rewritten app

* Remove console

* tests pass
@NullVoxPopuli NullVoxPopuli force-pushed the template-imports-2024-05 branch 2 times, most recently from 3b56344 to 539b9f8 Compare May 16, 2024 22:44
@NullVoxPopuli NullVoxPopuli added the enhancement New feature or request label May 16, 2024
@NullVoxPopuli NullVoxPopuli force-pushed the template-imports-2024-05 branch 12 times, most recently from 670f178 to 9a210d8 Compare May 21, 2024 20:31
NullVoxPopuli added a commit that referenced this pull request May 22, 2024
@NullVoxPopuli NullVoxPopuli changed the title Provide a separate template-plugin for better integration with template-transforms Proper Embroider Support May 22, 2024
@NullVoxPopuli
Copy link
Collaborator Author

This has been resolved in scoped-css @ 0.21.0

@NullVoxPopuli NullVoxPopuli deleted the template-imports-2024-05 branch June 13, 2024 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant