Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ale dc27 #157

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion arturito/src/components/HomeSection/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ const Button = ({ text, href }: { text: string; href: string }) => (
const HomeSection = () => (
<div className="p-3 space-y-3">
<p className="text-lg">¡Elegí una sección!</p>
<Button text="Documentación" href="https://www.swapi.it/documentation" />
<Button text="Documentación" href="https://swapi.dev/documentation" />
</div>
);

Expand Down
6 changes: 5 additions & 1 deletion arturito/src/components/PlanetsSection/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -43,9 +43,13 @@ const Planets = () => {

return (
<div>
<Table columns={columns} data={data.results.slice(0, 3)} /* :D */ />
<Table columns={columns} data={data.results} /* :D */ />

</div>
);
};

export default Planets;


//change line 46 <Table columns={columns} data={data.results.slice(0, 3)} /* :D */ />
8 changes: 4 additions & 4 deletions arturito/src/containers/Main/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -37,8 +37,8 @@ const MainContainer = () => {
films. Codear en un componente aparte tal como {'<Planets>'}.
</p>
<p>
<a href="https://swapi.it/documentation#starships">
https://swapi.it/documentation#starships
<a href="https://swapi.dev/documentation#starships">
https://swapi.dev/documentation#starships
</a>
</p>
</div>
Expand All @@ -53,8 +53,8 @@ const MainContainer = () => {
films. Codear en un componente aparte tal como {'<Planets>'}.
</p>
<p>
<a href="https://swapi.it/documentation#people">
https://swapi.it/documentation#people
<a href="https://swapi.dev/documentation#people">
https://swapi.dev/documentation#people
</a>
</p>
</div>
Expand Down
2 changes: 1 addition & 1 deletion arturito/src/utils/fetcher.ts
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import axios from 'axios';

// Possible alternative: 'https://swapi.dev/api'
const baseURL = 'https://www.swapi.it/api';
const baseURL = 'https://swapi.dev/api';

export const swGet = (url: string) =>
axios.get(url, { baseURL }).then((res) => res.data);
Empty file added arturito/text.txt
Empty file.