Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Django4.0 compatibility #211

Merged
merged 4 commits into from
Feb 2, 2022
Merged

Django4.0 compatibility #211

merged 4 commits into from
Feb 2, 2022

Conversation

aymaneMx
Copy link
Contributor

What does this do?

  • replace force_text with force_str
  • replace smart_text with smart_str
  • replace from django.conf.urls import url with from django.urls import re_path

closes: #206

@Real-Gecko
Copy link
Contributor

Can someone please arrange this? Really need Django upgrade.

@jheld
Copy link
Collaborator

jheld commented Jan 28, 2022

I will try to review & merge this weekend.

@BartKalkman
Copy link

I there any update on this. We need the new version.

@jheld
Copy link
Collaborator

jheld commented Feb 1, 2022

Sorry can you please add django 4.0 support into the .github/workflows/build.yml as that's where tests are officially run from?

@aymaneMx
Copy link
Contributor Author

aymaneMx commented Feb 1, 2022

@jheld sure

@jheld
Copy link
Collaborator

jheld commented Feb 1, 2022

@aymaneMx apologies but there is a bit more work to do on the test runner in github. Can you add similar exclude lines to what 3.2 has? I'll approve the test run now so we can easily see the failures but will wait to merge until those are configured differently.

@jheld jheld merged commit 9e29230 into soynatan:master Feb 2, 2022
@jheld
Copy link
Collaborator

jheld commented Feb 2, 2022

please see pypi for version 1.3.3a1. once we're happy with the stability, i'll cut the official release.

@jheld
Copy link
Collaborator

jheld commented Mar 18, 2022

how's the feedback? are we safe to cut the official release?

@Real-Gecko
Copy link
Contributor

I'm developing with Django 4 and Easy Audit since #213, haven't seen any errors so far. But thing to note I did not monitor Easy Audit closely too.

@mschoettle
Copy link
Contributor

mschoettle commented Apr 4, 2022

how's the feedback? are we safe to cut the official release?

I've been running Django 4.0.3 and 1.3.3a6 for a couple weeks now locally. It is working fine but it is not heavy use currently (new project). I submitted #226 to fix the default_app_config deprecation warning that I keep getting, would be nice to get that into the next release.

@jheld
Copy link
Collaborator

jheld commented Apr 7, 2022

release 1.3.3b1 is now PyPI and includes the fix on PR #226

Happy to cut the official release with an approval on usage of that version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Please Upgrade to django 4.0
5 participants