Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/be accessible nz #30

Open
wants to merge 39 commits into
base: main
Choose a base branch
from
Open

Feature/be accessible nz #30

wants to merge 39 commits into from

Conversation

bjoernuhlig
Copy link
Contributor

Ready for code review.

@bjoernuhlig
add media type in-room-compendium
6424a58
@bjoernuhlig
add media.test.ts test for in-room-compendium type of media
3e5985a
@bjoernuhlig
add to room property: hasWheelchairAccessiblePathFromOutside add test…
046bec4 
… for property
@bjoernuhlig
add property: providesMobilityEquipment to Accessiblity.ts add test f…
12b5948 
…or property
@bjoernuhlig
add properties hasAccessibilityAwarenessTraining and hasAccessibility…
9b164cf 
…AssistantForEnquiries to Staff.ts add test
@bjoernuhlig
add properties to staff add test
b8c6849
@bjoernuhlig
add pickUpOrDropOffZone?: Ground property to accessibility add tests
cbd6e8a
@bjoernuhlig
add pickUpOrDropOffZone?: Ground property to accessibility add tests
d96682b
@bjoernuhlig
temp changes
5ef7a84
@bjoernuhlig
add bed, roomAccessiblity, level, emergencyDevice object. add media t…
40c96e8 
…ype in-room-compendium. add properties hasWheelchairAccessiblePathFromOutside, hasAccessibleChairs, hasInfoPageUrl, isOnWheelchairAccessiblePath, hasDedicatedAccessibilitySignage. add room object as property to placeProperties object.
@bjoernuhlig
add & check for tests: EmergencyDevice && Level && RoomAccessibility …
2137f69 
…&& Bed
@bjoernuhlig bjoernuhlig requested a review from opyh May 25, 2020 10:29
@bjoernuhlig bjoernuhlig self-assigned this May 25, 2020
opyh
opyh requested changes May 26, 2020
View reviewed changes
Copy link
Member

@opyh opyh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thank you! Just some little things before we can merge this.

src/Accessibility.ts Outdated Show resolved Hide resolved
src/Accessibility.ts Outdated Show resolved Hide resolved
src/Accessibility.ts Outdated Show resolved Hide resolved
src/Accessibility.ts Outdated Show resolved Hide resolved
src/Bed.ts Outdated Show resolved Hide resolved
src/Room.ts Outdated Show resolved Hide resolved
src/Room.ts Outdated Show resolved Hide resolved
src/Room.ts Outdated Show resolved Hide resolved
src/Room.ts Outdated Show resolved Hide resolved
src/Staff.ts Outdated Show resolved Hide resolved
@opyh
Copy link
Member

opyh commented May 26, 2020

Could you fix the failing travis test, too?

@opyh opyh mentioned this pull request May 26, 2020
Closed
Björn Uhlig and others added 14 commits May 27, 2020 10:15
@opyh
Update src/Bed.ts
4419f1b 
Co-authored-by: Felix Zappe <sebastian@sozialhelden.de>
@opyh
Update src/Accessibility.ts
e2a466d 
Co-authored-by: Felix Zappe <sebastian@sozialhelden.de>
@opyh
Update src/Accessibility.ts
89f0e7e 
Co-authored-by: Felix Zappe <sebastian@sozialhelden.de>
@opyh
Update src/Accessibility.ts
7a02c78 
Co-authored-by: Felix Zappe <sebastian@sozialhelden.de>
@opyh
Update src/Room.ts
440c8e2 
Co-authored-by: Felix Zappe <sebastian@sozialhelden.de>
@opyh
Update src/Room.ts
e0e7925 
Co-authored-by: Felix Zappe <sebastian@sozialhelden.de>
@opyh
Update src/Room.ts
20dcb61 
Co-authored-by: Felix Zappe <sebastian@sozialhelden.de>
@opyh
Update src/Room.ts
657db89 
Co-authored-by: Felix Zappe <sebastian@sozialhelden.de>
@opyh
Update src/Bed.ts
9a1298f 
Co-authored-by: Felix Zappe <sebastian@sozialhelden.de>
@opyh
Update src/Accessibility.ts
6d730b9 
Co-authored-by: Felix Zappe <sebastian@sozialhelden.de>
@opyh
Update src/EmergencyDevice.ts
395af02 
Co-authored-by: Felix Zappe <sebastian@sozialhelden.de>
@opyh
Update src/EmergencyDevice.ts
c17a964 
Co-authored-by: Felix Zappe <sebastian@sozialhelden.de>
@opyh
Update src/EmergencyDevice.ts
333d270 
Co-authored-by: Felix Zappe <sebastian@sozialhelden.de>
@opyh
Update src/EmergencyDevice.ts
26ec30b 
Co-authored-by: Felix Zappe <sebastian@sozialhelden.de>
Björn Uhlig and others added 14 commits May 27, 2020 10:55
@opyh
Update src/EmergencyDevice.ts
65ab5c8 
Co-authored-by: Felix Zappe <sebastian@sozialhelden.de>
@opyh
Update src/EmergencyDevice.ts
284e909 
Co-authored-by: Felix Zappe <sebastian@sozialhelden.de>
@opyh
Update src/EmergencyDevice.ts
ce90f86 
Co-authored-by: Felix Zappe <sebastian@sozialhelden.de>
@opyh
Update src/EmergencyDevice.ts
15e92e8 
Co-authored-by: Felix Zappe <sebastian@sozialhelden.de>
@opyh
Update src/EmergencyDevice.ts
87f3c6d 
Co-authored-by: Felix Zappe <sebastian@sozialhelden.de>
@opyh
Update src/Level.ts
b2d2b38 
Co-authored-by: Felix Zappe <sebastian@sozialhelden.de>
@opyh
Update src/Level.ts
f30b8eb 
Co-authored-by: Felix Zappe <sebastian@sozialhelden.de>
@opyh
Update src/PlaceProperties.ts
7eee2a8 
Co-authored-by: Felix Zappe <sebastian@sozialhelden.de>
@opyh
Update src/Room.ts
e341ff6 
Co-authored-by: Felix Zappe <sebastian@sozialhelden.de>
@opyh
Update src/Room.ts
8cbfbb4 
Co-authored-by: Felix Zappe <sebastian@sozialhelden.de>
@bjoernuhlig
cleanup for pullreq and add test
d6b56a1
@opyh
Update src/Room.ts
020471f 
Co-authored-by: Felix Zappe <sebastian@sozialhelden.de>
@bjoernuhlig
change hasAccessibleChairs -> hasOneOrMoreAccessibleChairs
6857246
@bjoernuhlig
Merge branch 'feature/be-accessible-nz' of github.com:sozialhelden/a1…
f2364cc 
…1yjson into feature/be-accessible-nz
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@k00ni k00ni k00ni left review comments

@opyh opyh opyh requested changes

Assignees

@bjoernuhlig bjoernuhlig

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bjoernuhlig @opyh @k00ni