-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add node: users must explicitly set lat/lon #621
Comments
Sound good to me. Maybe it make sense to first set the marker position before the user can type in an address? |
@lennerd Right now it's the other way round: entering the address will readjust the map so people can find the area easier. My hunch is that we should keep that. |
Ah I see. Than there is also a Geolocation of the user we can use to bring him near to the area he probably wants to add a marker to. But I see your point. Just feels strange to start with optional fields and have the mandatory second. |
I do agree that Some thoughts:
If I am supposed to create a node I am usually aware of the => Isn't it better to request the user to be exact as they can from the beginning on and fix it later (because the place is identifiable even if the user uses just a random house number)? |
Current status: Waiting for @holgerd to clarify the points/ideas we discussed yesterday. |
I suggest the following for the location selection in the "add node" flow: 1. new initial page
2. user clicked on the map
|
@1000miles @Svenyo @lennerd What do you think? |
@holgerd Is there a reason why the headlines in the two pics differ (1. Click on the map to set its exact location, 2. Put a marker on the map)? Suggestion for slight change in the headline: "Zoom in and click on the map to set its exact location" It could be useful to allow putting the marker only on a high zoom level where we can be sure the exact position can be set. On a level too low the error message should appear: "Zoom in closer". Could we also offer the GPS location button here so that the user can jump to his/ her position which is displayed on the highest zoom level? |
I think the first flow looks good. I'm not sure about the second flow though as I would think it's dangerous because of the connection between map and pre-filling the address. Isn't that creating problems and inaccurate data again, because people rely on data on the map and do not check if the address is really correct? |
@lennerd @holgerd I agree with Lennart that the automatic pre-filling could be dangerous. However it would be good to have an suggestion popping up in case the user made a spelling error. Then there could be a red line under the entered street name saying: "Did you mean .... ?" |
👍 |
@Svenyo Good catch. The headline was a mistake. It should be as written in the text:
@lennerd and @Svenyo I saw that the OpenStreetMap editor iD is auto-guessing street names, but it happens in the form of auto-complete. So nothing is assumed beforehand. To de-risk and simplify this feature for now, I change my proposition regarding 2.:
means: never auto-fill an address. |
One addition: Map should default to zoom level 17 to make clear we want exact data. |
Thats a very nice idea! 👍 |
Following is a recap of the TODO tasks for #621. @holgerd cc @Svenyo @anngreenberg Holger, could you please confirm the recap task list? change
keep
|
Lgtm |
As discussed in the German OSM Forum, some users have difficulty with positioning a new node on wheelmap at the correct lat/lon.
Behavior now:
What I recommend changing:
The text was updated successfully, but these errors were encountered: