Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add node: users must explicitly set lat/lon #621

Open
holgerd opened this issue May 29, 2017 · 16 comments
Open

add node: users must explicitly set lat/lon #621

holgerd opened this issue May 29, 2017 · 16 comments
Assignees
Labels

Comments

@holgerd
Copy link
Member

holgerd commented May 29, 2017

As discussed in the German OSM Forum, some users have difficulty with positioning a new node on wheelmap at the correct lat/lon.

Behavior now:

wheelmap_-_find_wheelchair_accessible_places

  • ..and type an address into the form. The map on the right hand side automatically updates its location and the marker is set to the center of that map:

wheelmap_-_find_wheelchair_accessible_places

What I recommend changing:

  1. Add 2 titles to the columns: "1. address (optional)" and "2. point on the map (mandatory)"
  2. Do not pre-set the marker. Set it only after the user has clicked on the map (and if s/he just clicks next without lat/lon just gets an error message <-- this already is ok)
  3. change the help text to explain the new behavior.

wheelmap_-_find_wheelchair_accessible_places

@lennerd
Copy link
Collaborator

lennerd commented May 29, 2017

Sound good to me. Maybe it make sense to first set the marker position before the user can type in an address?

@holgerd
Copy link
Member Author

holgerd commented May 30, 2017

@lennerd Right now it's the other way round: entering the address will readjust the map so people can find the area easier. My hunch is that we should keep that.

@lennerd
Copy link
Collaborator

lennerd commented May 30, 2017

Ah I see. Than there is also a Geolocation of the user we can use to bring him near to the area he probably wants to add a marker to. But I see your point. Just feels strange to start with optional fields and have the mandatory second.

@1000miles
Copy link
Collaborator

I do agree that lat and lon should be mandatory in order to find duplicates along with names faster. I also agree that having optional fields in the first place while having mandatory in the second place is somehow opposite to the usual user experience.

Some thoughts:

  1. How about changing the position of the map and address input form, so that map is left (please mark first) and address is right (edit the address)?

  2. What is the value of keeping the address optional?

If I am supposed to create a node I am usually aware of the name, address and house number (e.g. a coffee shop, etc.) or at least the street or area of the entrance (e.g. park) in order to be exact as I can, or? How can I mark a place if I am not aware of at least a specific area?

=> Isn't it better to request the user to be exact as they can from the beginning on and fix it later (because the place is identifiable even if the user uses just a random house number)?

@1000miles
Copy link
Collaborator

Current status: Waiting for @holgerd to clarify the points/ideas we discussed yesterday.

@holgerd
Copy link
Member Author

holgerd commented Jun 8, 2017

I suggest the following for the location selection in the "add node" flow:

1. new initial page

balsamiq_mockups_for_desktop_-____users_hd_documents_sozialhelden_170608-add_node_bmml

  • changed headline: "Where is this place? Click on the map to set its exact location"
  • new: map on the left, address form on the right side
  • new: omit the info text "You can move the marker to the correct location on the map."
  • keep: map loads at users location if user gives permission in her browser
  • keep: show error message if user clicks "next" without setting the marker on the map.
  • omit additional info text (it's now the headline): "Bitte klicke in der Karte auf die Stelle, wo sich der Ort befindet!"
  • keep: address fields are not mandatory

2. user clicked on the map

balsamiq_mockups_for_desktop_-____users_hd_documents_sozialhelden_170608-add_node_bmml

  • keep: address is auto-filled on click on the map. It stops to auto-fill as soon as the user changed one of the fields
  • NEW: if user enters address in the form, it should have NO EFFECT to the position of the marker

@holgerd
Copy link
Member Author

holgerd commented Jun 8, 2017

@1000miles @Svenyo @lennerd What do you think?

@Svenyo
Copy link
Collaborator

Svenyo commented Jun 8, 2017

@holgerd
Yes, I think the flow is good like that.

Is there a reason why the headlines in the two pics differ (1. Click on the map to set its exact location, 2. Put a marker on the map)?

Suggestion for slight change in the headline: "Zoom in and click on the map to set its exact location"
If this is too long, maybe keep the info text that says instead: "Zoom in closer"

It could be useful to allow putting the marker only on a high zoom level where we can be sure the exact position can be set. On a level too low the error message should appear: "Zoom in closer".

Could we also offer the GPS location button here so that the user can jump to his/ her position which is displayed on the highest zoom level?

@lennerd
Copy link
Collaborator

lennerd commented Jun 13, 2017

I think the first flow looks good. I'm not sure about the second flow though as I would think it's dangerous because of the connection between map and pre-filling the address. Isn't that creating problems and inaccurate data again, because people rely on data on the map and do not check if the address is really correct?

@Svenyo
Copy link
Collaborator

Svenyo commented Jun 14, 2017

@lennerd @holgerd I agree with Lennart that the automatic pre-filling could be dangerous. However it would be good to have an suggestion popping up in case the user made a spelling error. Then there could be a red line under the entered street name saying: "Did you mean .... ?"
Like that we could avoid both: wrong addresses and typing mistakes.

@lennerd
Copy link
Collaborator

lennerd commented Jun 14, 2017

Then there could be a red line under the entered street name saying: "Did you mean .... ?"

👍

@holgerd
Copy link
Member Author

holgerd commented Jun 15, 2017

@Svenyo Good catch. The headline was a mistake. It should be as written in the text:

  • changed headline: "Where is this place? Click on the map to set its exact location"

@lennerd and @Svenyo I saw that the OpenStreetMap editor iD is auto-guessing street names, but it happens in the form of auto-complete. So nothing is assumed beforehand. To de-risk and simplify this feature for now, I change my proposition regarding 2.:

  • keep: REMOVE: address is auto-filled on click on the map. It stops to auto-fill as soon as the user changed one of the fields

means: never auto-fill an address.

@holgerd
Copy link
Member Author

holgerd commented Jun 15, 2017

One addition: Map should default to zoom level 17 to make clear we want exact data.

@lennerd
Copy link
Collaborator

lennerd commented Jun 15, 2017

I saw that the OpenStreetMap editor iD is auto-guessing street names, but it happens in the form of auto-complete.

Thats a very nice idea! 👍

@holgerd holgerd added this to the Start July 3rd milestone Jun 20, 2017
@1000miles 1000miles added the next label Aug 2, 2017
@1000miles
Copy link
Collaborator

1000miles commented Aug 7, 2017

Following is a recap of the TODO tasks for #621.

@holgerd cc @Svenyo @anngreenberg

Holger, could you please confirm the recap task list?

change

  • 1. user must click on marker first (mandatory), then on address field (optional) => change order: map to left, address fields to right
  • 2. change headline from Wo liegt der Ort? to Wo liegt der Ort? Bitte klicke in die Karte, um den exakten Ort zu markieren.
  • 3. remove additional text: Du kannst den Marker auf der Karte auf die korrekte Position verschieben.
  • 4. remove auto-fill completion in address fields
  • 5. map should default to zoom level 17
  • 6. add lon & lat to nodes-new-content-form

keep

  • if user approves allow location access the map loads the user's current geo location otherwise it will load the default location (currently Frankfurt am Main)
  • address fields are optional
  • do not allow to continue to next step (via next button) if no marker (step 1) has been set => show error message

@1000miles 1000miles added in progress and removed next labels Aug 7, 2017
@ghost ghost added on hold and removed in progress labels Aug 15, 2017
@holgerd
Copy link
Member Author

holgerd commented Aug 17, 2017

Lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants