Fix worker soft lock #1133
Merged
Fix worker soft lock #1133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… are full Signed-off-by: Eloi DEMOLIS <eloi.demolis@clever-cloud.com>
Signed-off-by: Eloi DEMOLIS <eloi.demolis@clever-cloud.com>
Wonshtrum
requested review from
FlorentinDUBOIS,
Keksoj and
llenotre
as code owners
Keksoj
reviewed
Aug 29, 2024
Keksoj
approved these changes
Aug 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #1132
In case Rustls buffers were full (default max capacity is 64kb), which can happen if the client connection is slow compared to the rate of response from the backend, an early break prevented the session from flushing these buffers on the socket, thus remaining full. An external loop kept retrying indefinitely until we killed the worker or the client closed the socket.