Cluster related metrics, user-agent #973

hcaumeil · 2023-08-02T14:28:26Z

Renaming gauge metrics that contains "count" in their name for consistency
Make back-end HTTP status metrics, 5.x.x sozu HTTP status metrics and access_logs metric cluster-related (see Improve metrics and access logs #937 ).
Add user agent in access logs (see Improve metrics and access logs #937 ).
Add time metrics related to path rules / domain rules matching (see Add some metrics (regex, lookup time) #804 ).

CLAassistant · 2023-08-02T14:28:34Z

All committers have signed the CLA.

doc/debugging_strategies.md

lib/src/protocol/kawa_h1/mod.rs

Keksoj

This seems very okay. I request changes for variable naming and code presentation, for a better legibility.

Thank you for contributing!

lib/src/http.rs

lib/src/https.rs

lib/src/metrics/mod.rs

lib/src/protocol/kawa_h1/mod.rs

lib/src/router/mod.rs

Keksoj

everything looks great to me now. Thanks!

doc/debugging_strategies.md

lib/src/logs.rs

Co-authored-by: Helian Caumeil <helian.caumeil@clever-cloud.com> Signed-off-by: Florentin Dubois <florentin.dubois@clever-cloud.com>

hcaumeil added 5 commits August 2, 2023 15:37

fix metrics macros import scopes

b8e1017

renaming metrics for consistancy

471c46f

make http status metrics and access logs metrics cluster related

9aee4da

add user-agent in access logs

11ff5bd

add path matching time metrics

8334bc7

hcaumeil requested review from FlorentinDUBOIS, Keksoj and Wonshtrum as code owners August 2, 2023 14:28

FlorentinDUBOIS requested changes Aug 2, 2023

View reviewed changes

doc/debugging_strategies.md Outdated Show resolved Hide resolved

lib/src/protocol/kawa_h1/mod.rs Outdated Show resolved Hide resolved

hcaumeil added 3 commits August 2, 2023 17:43

rename metric connections.error to backend.connections.error

6df1802

make http.301.redirection metric cluster related

e8caac8

Merge branch 'main' into metrics

c0d2e55

Keksoj requested changes Aug 2, 2023

View reviewed changes

hcaumeil added 3 commits August 3, 2023 11:07

cleaner error handling

295c2b6

better formating

0acf06d

variable rename for clarity

3feeca8

Keksoj approved these changes Aug 3, 2023

View reviewed changes

FlorentinDUBOIS reviewed Aug 7, 2023

View reviewed changes

doc/debugging_strategies.md Show resolved Hide resolved

hcaumeil added 2 commits August 8, 2023 12:14

rename up and down metrics for clarity

182b579

make some http 4.x.x status metrics clustered (401,408,413)

c2b4c9c

hcaumeil force-pushed the metrics branch from 467987c to c2b4c9c Compare August 8, 2023 10:19

FlorentinDUBOIS reviewed Aug 8, 2023

View reviewed changes

lib/src/logs.rs Outdated Show resolved Hide resolved

hcaumeil force-pushed the metrics branch from 0494c11 to 4288c77 Compare August 8, 2023 15:50

chore: print user-agent as a tag value in access logs

0ecf4cc

Co-authored-by: Helian Caumeil <helian.caumeil@clever-cloud.com> Signed-off-by: Florentin Dubois <florentin.dubois@clever-cloud.com>

hcaumeil force-pushed the metrics branch from 4288c77 to c2b4c9c Compare August 8, 2023 16:53

FlorentinDUBOIS approved these changes Aug 8, 2023

View reviewed changes

FlorentinDUBOIS merged commit 2a856d8 into sozu-proxy:main Aug 8, 2023
6 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Cluster related metrics, user-agent #973

Cluster related metrics, user-agent #973

hcaumeil commented Aug 2, 2023

CLAassistant commented Aug 2, 2023 •

edited

Loading

Keksoj left a comment

Keksoj left a comment

Cluster related metrics, user-agent #973

Cluster related metrics, user-agent #973

Conversation

hcaumeil commented Aug 2, 2023

CLAassistant commented Aug 2, 2023 • edited Loading

Keksoj left a comment

Choose a reason for hiding this comment

Keksoj left a comment

Choose a reason for hiding this comment

CLAassistant commented Aug 2, 2023 •

edited

Loading