Opcache: Key $value for the array should be unique

[oyeaussie]

file_put_contents(base_path($this->storagePath . $this->directory . '/' . $key), '<?php $value = ' . $value . ';', LOCK_EX);

The above command $value is the variable that is used for lookup. If there are 2 more files in opcache, this value will be overwritten.

Possible solution:

    public function getCache($key, $directory = null)
    {
        $this->setDirectory($directory);

        try {
            include base_path($this->storagePath . $this->directory . '/' . $key);
        } catch (\throwable $e) {
            return false;
        }

        return ${"value_".$key} ?? false;
    }

    public function setCache($key, $value, $directory = null)
    {
        $this->setDirectory($directory);

        $value = var_export($value, true);

        $value = str_replace('stdClass::__set_state', '(object)', $value);

        file_put_contents(base_path($this->storagePath . $this->directory . '/' . $key), '<?php $value_' . $key . ' = ' . $value . ';', LOCK_EX);

        return $this->getCache($key, $directory);
    }

######## Issue imported from Gitea ########

Details

Gitea Issue ID : 593
State : open
Created : 2024-06-20T18:46:35+10:00

Issue Description

file_put_contents(base_path($this->storagePath . $this->directory . '/' . $key), '<?php $value = ' . $value . ';', LOCK_EX);

The above command $value is the variable that is used for lookup. If there are 2 more files in opcache, this value will be overwritten.

Possible solution:

    public function getCache($key, $directory = null)
    {
        $this->setDirectory($directory);

        try {
            include base_path($this->storagePath . $this->directory . '/' . $key);
        } catch (\throwable $e) {
            return false;
        }

        return ${"value_".$key} ?? false;
    }

    public function setCache($key, $value, $directory = null)
    {
        $this->setDirectory($directory);

        $value = var_export($value, true);

        $value = str_replace('stdClass::__set_state', '(object)', $value);

        file_put_contents(base_path($this->storagePath . $this->directory . '/' . $key), '<?php $value_' . $key . ' = ' . $value . ';', LOCK_EX);

        return $this->getCache($key, $directory);
    }

Timeline

Label : Added bug on 2024-06-20T18:46:35+10:00.
Label : Added P3 on 2024-06-20T18:46:35+10:00.
Milestone : Added 0.0.0-rc.5 on 2024-07-02T12:21:16+10:00.