Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Auth: Move generate new pw and check pw strength out of basecomponent #531

Closed
oyeaussie opened this issue Jul 6, 2024 · 0 comments · Fixed by #532
Closed

Auth: Move generate new pw and check pw strength out of basecomponent #531

oyeaussie opened this issue Jul 6, 2024 · 0 comments · Fixed by #532
Assignees
@oyeaussie
Labels
bug Something is not working P3 I will get to this in a week or a month, bribe me to prioritise
Milestone
0.0.0-rc.5

Comments

@oyeaussie
Copy link
Contributor

Auth is responsible for passwords. There are duplicate methods one in BaseComponent and one in AuthComponent. Remove method from BaseComponent.
@oyeaussie oyeaussie added bug Something is not working P3 I will get to this in a week or a month, bribe me to prioritise labels Jul 6, 2024
@oyeaussie oyeaussie added this to the 0.0.0-rc.5 milestone Jul 6, 2024
@oyeaussie oyeaussie self-assigned this Jul 6, 2024
oyeaussie added a commit that referenced this issue Jul 6, 2024
@oyeaussie
Update #531
4153928 
- Removed methods from BaseComponent
- Removed methods from Auth.
@oyeaussie oyeaussie linked a pull request Jul 6, 2024 that will close this issue
Update #531 #532
Merged
oyeaussie added a commit that referenced this issue Jul 6, 2024
@oyeaussie
Merge pull request #532 from sp-framework/531-auth-move-generate-new-…
8c5a2f8 
…pw-and-check-pw-strength-out-of-basecomponent

Update #531
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oyeaussie oyeaussie

Labels
bug Something is not working P3 I will get to this in a week or a month, bribe me to prioritise
Projects
None yet
Milestone
0.0.0-rc.5
Development

Successfully merging a pull request may close this issue.

Update #531 sp-framework/core
1 participant
@oyeaussie