Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AccessServiceProvider: Move Auth, Acl, AgentCheck, IpFilter under Access #540

Closed
oyeaussie opened this issue Jul 7, 2024 · 0 comments
Closed

AccessServiceProvider: Move Auth, Acl, AgentCheck, IpFilter under Access #540

oyeaussie opened this issue Jul 7, 2024 · 0 comments
Assignees
@oyeaussie
Labels
P2 If not fixed, how will I sleep tonight task Perform a Task
Milestone
0.0.0-rc.6

Comments

@oyeaussie
Copy link
Contributor

oyeaussie commented Jul 7, 2024 •
edited
Loading

Access service provider has grown from just authentication to :

  • Authentication
  • Acl
  • AgentCheck
  • IpFilter (currently part of apps, but will be moved under access)

In order to access Auth, we use $this->auth. After we move to access auth can be accessed via $this->access->auth and so on.
@oyeaussie oyeaussie changed the title Auth: Move Auth under Access AccessServiceProvider: Move Auth, Acl, AgentCheck, IpFilter under Access Jul 7, 2024
@oyeaussie oyeaussie self-assigned this Jul 7, 2024
@oyeaussie oyeaussie added P2 If not fixed, how will I sleep tonight task Perform a Task labels Jul 7, 2024
@oyeaussie oyeaussie added this to the 0.0.0-rc.6 milestone Jul 7, 2024
This was referenced Jul 7, 2024
Closed
Closed
oyeaussie added a commit that referenced this issue Jul 7, 2024
@oyeaussie
Initial Commit #540
9edc118
oyeaussie added a commit that referenced this issue Jul 8, 2024
@oyeaussie
Update #540
30268a8 
- Moved password and twofa in their own class under Auth
oyeaussie added a commit that referenced this issue Jul 8, 2024
@oyeaussie
update #540
53c9b4b 
- Testing and fixing bugs.
This was referenced Jul 8, 2024
Closed
Closed
oyeaussie added a commit that referenced this issue Jul 8, 2024
@oyeaussie
Update #540
5f92acd 
- Fix minor positioning of validation of password during login.
@oyeaussie oyeaussie linked a pull request Jul 8, 2024 that will close this issue
540 accessserviceprovider move auth acl agentcheck ipfilter under access #546
Merged
@oyeaussie oyeaussie removed a link to a pull request Jul 8, 2024
540 accessserviceprovider move auth acl agentcheck ipfilter under access #546
Merged
oyeaussie added a commit that referenced this issue Jul 9, 2024
@oyeaussie
update #540
916e185 
- Remove constructor from acl as we are inheriting basepackage
oyeaussie added a commit that referenced this issue Jul 9, 2024
@oyeaussie
update #540
2d6251a 
- Fix bug with loop caused because of oldSessionId in addUpdateAgent.
- Minor cleanups.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oyeaussie oyeaussie

Labels
P2 If not fixed, how will I sleep tonight task Perform a Task
Projects
None yet
Milestone
0.0.0-rc.6
Development

No branches or pull requests
1 participant
@oyeaussie