Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #551 #552

Merged
merged 1 commit into from
Jul 9, 2024
Merged

Fix #551 #552

merged 1 commit into from
Jul 9, 2024

Conversation

oyeaussie
Copy link
Contributor

  • We need to loop through the intermediate models first as when we remove data from direct model, we can no longer check the intermediate data as the original ids are lost.
  • Also, not all intermediate needs to be deleted, so added an exclusion to the remove method.

@oyeaussie
Fix #551
d991b05 
- We need to loop through the intermediate models first as when we remove data from direct model, we can no longer check the intermediate data as the original ids are lost.
- Also, not all intermediate needs to be deleted, so added an exclusion to the remove method.
@oyeaussie oyeaussie linked an issue Jul 9, 2024 that may be closed by this pull request
FF: Related data not being removed if the relation is intermediate #551
Closed
@oyeaussie oyeaussie merged commit 26eb78b into dev Jul 9, 2024
@oyeaussie oyeaussie deleted the 551-ff-related-data-not-being-removed-if-the-relation-is-intermediate branch July 9, 2024 04:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

FF: Related data not being removed if the relation is intermediate
1 participant
@oyeaussie