patch 3.2.0 #4
Open
patch 3.2.0 #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/backend/serial/u64/field.rs
Outdated
Comment on lines
254
to
268
| pub(crate) const fn from_limbs(limbs: [u64; 5]) -> FieldElement51 { | ||
| FieldElement51(limbs) | ||
| } | ||
| /// The scalar \\( 0 \\). | ||
| pub const ZERO: FieldElement51 = FieldElement51::from_limbs([0, 0, 0, 0, 0]); | ||
| /// The scalar \\( 1 \\). | ||
| pub const ONE: FieldElement51 = FieldElement51::from_limbs([1, 0, 0, 0, 0]); | ||
| /// The scalar \\( -1 \\). | ||
| pub const MINUS_ONE: FieldElement51 = FieldElement51::from_limbs([ | ||
| 2251799813685228, | ||
| 2251799813685247, | ||
| 2251799813685247, | ||
| 2251799813685247, | ||
| 2251799813685247, | ||
| ]); |
There was a problem hiding this comment.
It's from patch 4.1.3. We mostly just need ONE for the patch so I can delete ZERO and MINUS_ONE
Comment on lines
+824
to
+833
| /// Get the bits of the scalar, in little-endian order | ||
| pub(crate) fn bits_le(&self) -> impl DoubleEndedIterator<Item = bool> + '_ { | ||
| (0..256).map(move |i| { | ||
| // As i runs from 0..256, the bottom 3 bits index the bit, while the upper bits index | ||
| // the byte. Since self.bytes is little-endian at the byte level, this iterator is | ||
| // little-endian on the bit level | ||
| ((self.bytes[i >> 3] >> (i & 7)) & 1u8) == 1 | ||
| }) | ||
| } | ||
|
|
There was a problem hiding this comment.
need it for let a_bits = a.bits_le().collect::<Vec>(); in vartime_double_base.rs (from 4.1.3 patch)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.