Improve the error message when all configured hubs failed to connect. #189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I found the "partial error" message to basicly only be useful if you *actually* have multiple hubs setup. Else it's just confusing to the end player... what is a server hub configuration? Instead, if we get ZERO servers from any of the hubs, we return the regular error. If we get partial results from some hubs, we can use the partial error like before. Slightly improves the error message to suggest a solution and for this change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found the "partial error" message to basicly only be useful if you actually have multiple hubs setup. Else it's just confusing to the end player... what is a server hub configuration?
Instead, if we get ZERO servers from any of the hubs, we return the regular error. If we get partial results from some hubs, we can use the partial error like before.
Even if you only have one hub and somehow connected sucessfully... something must have gone wrong if NO servers are on the hub, before this would just show... no error. Now the user gets feedback something is wrong.
Slightly improves the error message to suggest a solution and for this change.