Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix error when pulling a buckled entity #1510

Merged
merged 2 commits into from
Jul 28, 2020
Merged

Fix error when pulling a buckled entity #1510

merged 2 commits into from
Jul 28, 2020

Conversation

DrSmugleaf
Copy link
Member

Fixes #1499

@DrSmugleaf DrSmugleaf added Feature: Interaction T: Bugfix Type: Bugs and/or bugfixes labels Jul 27, 2020
ShadowCommander
ShadowCommander reviewed Jul 27, 2020
View reviewed changes
Copy link
Member

@ShadowCommander ShadowCommander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel like it'd be better just to define var buckledTo = BuckledTo earlier and just use buckledTo in place of all of them.

@DrSmugleaf
Copy link
Member Author

DrSmugleaf commented Jul 27, 2020 •
edited
Loading

I feel like it'd be better just to define var buckledTo = BuckledTo earlier and just use buckledTo in place of all of them.

I can do that, though it is moved there because that's the earliest that any state change happens to the component or its owner.

@Acruid Acruid merged commit 264062c into space-wizards:master Jul 28, 2020
@DrSmugleaf DrSmugleaf deleted the buckle-pulling-fix-1499 branch November 8, 2021 12:55
rbertoche pushed a commit to rbertoche/space-station-14 that referenced this pull request Apr 22, 2023
@FluffiestFloof
Put a job locked weapon in the job category (space-wizards#1510)
4b4ddb4
Erisfiregamer1 pushed a commit to The-Arcadis-Team/arc-station-14 that referenced this pull request Jan 13, 2025
@LonoferaRS
[Add] More Winter Coats in Loadout (space-wizards#1510)
4d384c9 
# Description

i may be stupid....
Closes Simple-Station/Einstein-Engines#1473

---

# Changelog

:cl:
- add: A bunch of winter coats that are already in the game were added
as a loadouts.
Erisfiregamer1 pushed a commit to The-Arcadis-Team/arc-station-14 that referenced this pull request Jan 13, 2025
@SimpleStation14
Automatic Changelog Update (space-wizards#1510)
72cc963
rhit-eppersac pushed a commit to Kandiyaki/space-station-14 that referenced this pull request Feb 10, 2025
@hivehum
Merge pull request space-wizards#1510 from AvianMaiden/Machine-state-…
e62a687 
…your-laws

Law Board Descriptions!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PJB3005 PJB3005 Awaiting requested review from PJB3005

@gradientvera gradientvera Awaiting requested review from gradientvera

@ShadowCommander ShadowCommander Awaiting requested review from ShadowCommander

Assignees
No one assigned
Labels
T: Bugfix Type: Bugs and/or bugfixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Pulling someone who's buckled to something throws an exception.
3 participants
@DrSmugleaf @ShadowCommander @Acruid