Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix removehand throwing exception when no hand exists #1570

Merged
merged 2 commits into from
Aug 2, 2020
Merged

Fix removehand throwing exception when no hand exists #1570

merged 2 commits into from
Aug 2, 2020

Conversation

exp111
Copy link
Member

@exp111 exp111 commented Aug 2, 2020

See #1488

gradientvera
gradientvera suggested changes Aug 2, 2020
View reviewed changes
Copy link
Contributor

@gradientvera gradientvera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe send a message to the console saying "invalid hand." if this is the case?

@exp111 exp111 requested a review from gradientvera August 2, 2020 15:00
@gradientvera gradientvera merged commit a73c5ba into space-wizards:master Aug 2, 2020
@DrSmugleaf DrSmugleaf added Feature: Entities T: Bugfix Type: Bugs and/or bugfixes labels Aug 11, 2020
rbertoche pushed a commit to rbertoche/space-station-14 that referenced this pull request May 19, 2023
@Elijahrane
cleanup turtle skirt commit (space-wizards#1570)
5f90a8a
TheArturZh referenced this pull request in TheArturZh/space-station-14 Nov 28, 2023
@lapatison @TheArturZh
Translate Upstream SerbiaStrong-220#1570 (SerbiaStrong-220#1571)
a1b9ed1
rbertoche pushed a commit to rbertoche/space-station-14 that referenced this pull request Jul 4, 2024
@whatston3 @PJB3005
Remove placing items on tabletop boards. (space-wizards#29513) (space…
4196b94 
…-wizards#1570)

This feature should never have been merged, it can be trivially abused to break the entire server.

It's behind a CVar because honestly that's the easiest way to 1984 the feature.

Co-authored-by: Pieter-Jan Briers <pieterjan.briers+git@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gradientvera gradientvera gradientvera approved these changes

@PJB3005 PJB3005 Awaiting requested review from PJB3005

Assignees
No one assigned
Labels
T: Bugfix Type: Bugs and/or bugfixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@exp111 @gradientvera @DrSmugleaf