Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New revolver Rex #16211

Closed
wants to merge 3 commits into from
Closed

Conversation

Jackal298
Copy link
Contributor

@Jackal298 Jackal298 commented May 7, 2023

After improving revolvers, cargo has a new order

About the PR

This pr already was (I accidentally deleted it) and I know that it will be frozen, but I will leave it if you need an order for a revolver in cargo

What's the point?

After the improvement of the .45 Magnum cartridge, revolvers became good weapons, and then a moment arose that a revolver can only be legally obtained for certain roles or with very good luck.
Revolver Inspector for detective or small chance in crate salvage
Revolver Python for the Syndicate or with a small chance from seman Gatfruit (which will definitely be taken by security guards)
Revolver Mateba personal weapon ERT
Deckard revolver with very low chance in salvage crate or single in station storage (or armory)
Pirate revolver at the pirates

I made a revolver that won't create confusion during the RP process
In terms of combat characteristics, this is a complete analogue of the inspector revolver (until I figure out how best to make the revolvers differ not only in the size of the drum)
A revolver can be used to equip a boss who survived an unsuccessful attempt on his life, who needs a weapon for self-defense, for a security officer who has distinguished himself well, for salvages who need good firepower when fighting a bear or during an expedition.

When ordering in cargo for 1200 credits you will receive: one revolver, three speedloaders

Thanks TaralGit for the updated icon sprite

Media

1 rex
2 rex
3 rex

  • I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Changelog

🆑

  • add: NT has signed a contract with private gunsmiths for the supply of the revolver Rex

After improving revolvers, cargo has a new order
@Jackal298 Jackal298 requested a review from RemieRichards as a code owner May 7, 2023 11:38
@github-actions github-actions bot added S: Needs Review Status: Requires additional reviews before being fully accepted Changes: Sprites Changes: Might require knowledge of spriting or visual design. Changes: No C# Changes: Requires no C# knowledge to review or fix this item. labels May 7, 2023
@github-actions
Copy link
Contributor

github-actions bot commented May 7, 2023

RSI Diff Bot; head commit c093cbd merging into 5c86778
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/Objects/Weapons/Guns/Revolvers/rex.rsi

State Old New Status
equipped-BELT Added
icon Added
inhand-left Added
inhand-right Added

Edit: diff updated after c093cbd

@AJCM-git AJCM-git added the S: Frozen Status: Affects a game area that's frozen. Check "Current Freezes" in the Issues tab. label May 7, 2023
@AJCM-git
Copy link
Member

AJCM-git commented May 7, 2023

There is a content freeze on new guns, see #8524 (i know you know but its always good to link on new prs)

@Jackal298
Copy link
Contributor Author

There is a content freeze on new guns, see #8524 (i know you know but its always good to link on new prs)

I understand

@@ -12,3 +12,6 @@ ent-CrateArmoryLaser = lasers crate

ent-CrateArmoryPistols = pistols crate
.desc = Contains two standard NT pistols with four mags. Requires Armory access to open.

ent-CrateRevolver = revolver crate
.desc = Crate with one reliable Rex revolver, a revolver in case there is a threat for which a regular pistol will not be enough. Requires Armory access to open.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

revolver said twice sounds bad change the second to weapon or gun maybe
in case -> incase

@@ -48,3 +48,14 @@
amount: 2
- id: MagazinePistol
amount: 4

- type: entity
id: CrateRevolver
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

id should have rex since there are other revolvers in the game

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

id should have rex since there are other revolvers in the game

I can do CrateRevolverRex, it's all right?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ye

name: Rex
parent: BaseWeaponRevolver
id: WeaponRevolverRex
description: Robust revolver with rubberized grip and stainless steel finish, a good argument in dangerous situations. Uses .45 magnum ammo.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a rubberized grip

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: No C# Changes: Requires no C# knowledge to review or fix this item. Changes: Sprites Changes: Might require knowledge of spriting or visual design. S: Frozen Status: Affects a game area that's frozen. Check "Current Freezes" in the Issues tab. S: Needs Review Status: Requires additional reviews before being fully accepted
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants