Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mouse rotator system #19267

Merged

Conversation

mirrorcult
Copy link
Contributor

@mirrorcult mirrorcult commented Aug 18, 2023

About the PR

component for entities to control their rotation through mouse movement rather than clicking/rotatetoface

mostly for ship guns later (and stuff like player controlled turrets now). but i do want to experiment with this for players/player-controllables at some point in the future

maybe also support rotation speed? not sure if that predicts well

also components to override the default rotate on move/interact behavior

Media

  • I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase
2023-08-17_20-19-34.mp4

lerping

2023-08-18_15-59-43.mp4

@mirrorcult mirrorcult requested a review from ElectroJr as a code owner August 18, 2023 01:23
@github-actions github-actions bot added the S: Needs Review Status: Requires additional reviews before being fully accepted label Aug 18, 2023
@metalgearsloth
Copy link
Contributor

I think 13 calls it strafing

@mirrorcult
Copy link
Contributor Author

image
copy baste from discord

@mirrorcult mirrorcult marked this pull request as draft August 18, 2023 02:28
@mirrorcult
Copy link
Contributor Author

actually draft cuz i can improve this a lot

@mirrorcult
Copy link
Contributor Author

ok added configurable tolerance and non instant rotation

@mirrorcult mirrorcult marked this pull request as ready for review August 18, 2023 21:03
@github-actions github-actions bot added the S: Merge Conflict Status: Needs to resolve merge conflicts before it can be accepted label Aug 30, 2023
@github-actions
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@mirrorcult
Copy link
Contributor Author

mirrorcult commented Sep 1, 2023

probably still need to profile how many events are getting sent depending on threshold tbh

@github-actions github-actions bot removed the S: Merge Conflict Status: Needs to resolve merge conflicts before it can be accepted label Sep 1, 2023
@github-actions github-actions bot added the S: Merge Conflict Status: Needs to resolve merge conflicts before it can be accepted label Sep 9, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Sep 9, 2023

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@metalgearsloth
Copy link
Contributor

Needs update for action entities.

@metalgearsloth metalgearsloth added S: Awaiting Changes Status: Changes are required before another review can happen and removed S: Needs Review Status: Requires additional reviews before being fully accepted labels Sep 16, 2023
# Conflicts:
#	Content.Shared/CombatMode/CombatModeComponent.cs
#	Content.Shared/CombatMode/SharedCombatModeSystem.cs
#	Content.Shared/Movement/Systems/SharedMoverController.cs
#	Resources/Prototypes/Entities/Mobs/NPCs/animals.yml
#	Resources/Prototypes/Entities/Objects/Weapons/Guns/turrets.yml
@github-actions github-actions bot removed the S: Merge Conflict Status: Needs to resolve merge conflicts before it can be accepted label Sep 22, 2023
@mirrorcult mirrorcult added S: Needs Review Status: Requires additional reviews before being fully accepted and removed S: Awaiting Changes Status: Changes are required before another review can happen labels Sep 22, 2023
@mirrorcult
Copy link
Contributor Author

fixed for actiontities

@metalgearsloth metalgearsloth merged commit b8b4e91 into space-wizards:master Sep 23, 2023
BasedUser pushed a commit to cube-station-14/cube-station-14 that referenced this pull request Oct 6, 2023
Co-authored-by: metalgearsloth <31366439+metalgearsloth@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S: Needs Review Status: Requires additional reviews before being fully accepted
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants