Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Frog with horns #24670

Closed
wants to merge 6 commits into from
Closed

Frog with horns #24670

wants to merge 6 commits into from

Conversation

Strol20
Copy link
Contributor

@Strol20 Strol20 commented Jan 28, 2024 •
edited
Loading

About the PR

I added a frog with horns to the game (This is an existing species of frogs, although they do not have such large horns)

Why / Balance

I just thought it would be fun

Technical details

Media

image

  • I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Breaking changes

Changelog

@github-actions github-actions bot added Changes: Sprites Changes: Might require knowledge of spriting or visual design. Changes: No C# Changes: Requires no C# knowledge to review or fix this item. labels Jan 28, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 28, 2024 •
edited
Loading

RSI Diff Bot; head commit 3cc8375 merging into 27707c0
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/Mobs/Animals/froghorns.rsi

State Old New Status
dead Added
frog-moving Added
frog Added

Edit: diff updated after 3cc8375

@Strol20 Strol20 requested a review from icekot8 January 28, 2024 17:11
@github-actions github-actions bot added the S: Needs Review Status: Requires additional reviews before being fully accepted label Jan 28, 2024
icekot8
icekot8 approved these changes Jan 28, 2024
View reviewed changes
Copy link
Contributor

@icekot8 icekot8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all right 👍

@UbaserB
Copy link
Member

UbaserB commented Mar 12, 2024

This PR is frozen now, as based on #8524

@UbaserB UbaserB added the S: Frozen Status: Affects a game area that's frozen. Check "Current Freezes" in the Issues tab. label Mar 12, 2024
@Emisse
Copy link
Contributor

Emisse commented May 10, 2024

Closed due to feature freeze May 10th-June 14th. Comment to have it reopen after this.

@Emisse Emisse closed this May 10, 2024
@TokenStyle
Copy link
Contributor

Reopen pls, we need this

@Strol20
Copy link
Contributor Author

Strol20 commented Aug 14, 2024

Closed due to feature freeze May 10th-June 14th. Comment to have it reopen after this.

Please, open this pr

@slarticodefast
Copy link
Member

Could you merge the master branch so that the tests can rerun properly? No idea why the labeler fails, might be because this PR is quite old by now.

@lzk228
Copy link
Contributor

lzk228 commented Aug 19, 2024

btw cl should be removed, this mob not even used anywhere

@VasilisThePikachu VasilisThePikachu removed Feature Freeze: Closed from May 10 to June 14 S: Frozen Status: Affects a game area that's frozen. Check "Current Freezes" in the Issues tab. labels Aug 19, 2024
@slarticodefast slarticodefast added the S: Undergoing Maintainer Discussion Status: Currently going through an extended discussion amongst maintainers, as per procedure. label Aug 20, 2024
@slarticodefast
Copy link
Member

Hey, I brought this up for discussion with the other maintainers and the agreement was not to include this mob as it is has no use in the game at the moment. Thank you for your contribution.

@UbaserB UbaserB removed the S: Undergoing Maintainer Discussion Status: Currently going through an extended discussion amongst maintainers, as per procedure. label Aug 25, 2024
@Strol20
Copy link
Contributor Author

Strol20 commented Sep 8, 2024

Hey, I brought this up for discussion with the other maintainers and the agreement was not to include this mob as it is has no use in the game at the moment. Thank you for your contribution.

Maybe it is possible to add a chance that instead of a normal frog there will be a frog with horns?

@slarticodefast
Copy link
Member

Maybe it is possible to add a chance that instead of a normal frog there will be a frog with horns?

I guess it would be fine? Our art directors had some issues with the sprite though, so it would have to be redrawn.
@UbaserB

@UbaserB
Copy link
Member

UbaserB commented Sep 9, 2024

The eyes/mouth does not really look like a frog and the horns should be placed so that its not protruding out of the eyes its sort of weird

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@icekot8 icekot8 icekot8 approved these changes

Assignees
No one assigned
Labels
Changes: No C# Changes: Requires no C# knowledge to review or fix this item. Changes: Sprites Changes: Might require knowledge of spriting or visual design. S: Needs Review Status: Requires additional reviews before being fully accepted
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@Strol20 @UbaserB @Emisse @TokenStyle @slarticodefast @lzk228 @icekot8 @mirrorcult @VasilisThePikachu