Radio jammer update!

[beck-thompson]

About the PR

Radio jammer now has selectable power levels and a battery level indicator light!

Why / Balance

The radio jammers default range of 8 was relatively large for most situations. Expanding its functionality with the three selectable ranges gives it a lot more utility. Now, you can privately threaten CMO without the rest of medical losing radio access! Or, you could crank up the power to max and, for a short period of time, completely black out all of security from hearing the HOPs cries for help. This will give antagonists more control (And ability to mess up!) in executing plots involving the radio jammer!

Technical details

The main thing that was implemented was adding a OnGetVerb function that adds the menu for selecting the power level. I also created two functions GetCurrentWattage and GetCurrentRange because now that they can change the jammer system needs a way to determine what the current range / wattage is. For the battery level indicator, I just switch the sprite to a new level depending on the battery power.

Media

radiojammer.webm

batt.webm

Changelog

🆑 Beck Thompson

• tweak: Radio jammer now has 3 selectable power operating levels and a battery level led indicator!

[github-actions]

RSI Diff Bot; head commit 84cf50f merging into 5b0c3ec
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/Objects/Devices/jammer.rsi

State	Old	New	Status
jammer			Modified
jammer_high_charge			Added
jammer_low_charge			Added
jammer_medium_charge			Added

Edit: diff updated after 84cf50f

[beck-thompson]

This is the new PR after I nuked the old one: #25546

@metalgearsloth Here are the commits that fix the stuff you wanted! Let me know if its right.

fc50e37
f93e85d
28e29b4
22f061a

[Flareguy]

The radio jammer absolutely could use a resprite, but I'm not a very big fan of this.
The dish looks very out-of-place on the radio jammer. I'm not 100% confident why that is, but there are a few possible culprits from what I can tell:

• The coloration and shading does not fit with the rest of the item
• The rim of the dish is too contrast-y and should probably just use colors picked from or just above the radio jammer's body
• The dish is probably way too big

The dish is also fairly out of style feeling, probably mainly due to its hueshifting and lack of outlines in some spots. For hueshifting, you should probably reduce it to somewhere around 1-2 hue difference per color increment at most, or just opt to not hueshift it at all.

[beck-thompson]

Thanks for the feedback! Sounds like I totally missed the mark on the sprite (Fair enough 😆). It took me a while to make as I don't have much experience (one udemy pixel art class a few years ago). Next week is finals week and I just don't have the time to make the requested changes as it will probably take a few iterations.

I'll just remove it and I (Or someone else!) can update it later.

[github-actions]

This pull request has conflicts, please resolve those before we can evaluate the pull request.

[Dueu]

Ain't a way to code it so it doesn't block syndie comms?

[beck-thompson]

Maybe but I personally think that's a little weird! It makes sense it that it blocks ALL communication / radio transmissions. What could be interesting is adding a new menu where you can choose what channels to block (E.g block sec and command coms but leave the rest open) but that's out of the scope for this PR (Also from what I heard the radio code is kind of a mess so it might not be as easy as you'd expect?).

[metalgearsloth]

Just have the server system inherit the shared one instead of running 2 different systems ingame.

[beck-thompson]

I think I fixed this now!

b

[beck-thompson]

Yay! Thanks to everyone who helped / reviewed this! Ya'll put a a lot of effort to help me and I appreciate it :)
(I learned quite a lot 😆)