Added Yip Yip the kobold bartender

[PolterTzi]

About the PR

Adds a kobold equivalent for Pun Pun.

Why / Balance

WEH

Media

• I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Changelog

🆑

• add: A kobold might show up in Pun Pun's place.

[Simyon264]

FYI: There is a freeze on new pets.

New pets. While fluff is nice we have enough cargo-obtainable fluff animals and department mascots, to add new animals they must have something interesting like new AI behaviors or spawn in proc gen maps.

See #8524 for more info. This PR may be closed any time by a maintaner.

[Errant-4]

At this point it might make sense to create a second parent for the bartender animals to inherit the common components without having to redefine them every time

[VasilisThePikachu]

FYI: There is a freeze on new pets.

New pets. While fluff is nice we have enough cargo-obtainable fluff animals and department mascots, to add new animals they must have something interesting like new AI behaviors or spawn in proc gen maps.

See #8524 for more info. This PR may be closed any time by a maintaner.

It wont be closed but not merged any time soon.

[PolterTzi]

Ah, darn.
Oh well.

[VasilisThePikachu]

Though I will leave one review

[VasilisThePikachu]

I would suggest you rename the id as well and add a migration to change the old id to the new one

https://github.com/space-wizards/space-station-14/blob/master/Resources/migration.yml

[TheShuEd]

I think it's fine and doesn't really fall under the freeze, since it's not adding a new ghost role, but randomizing the appearance of an existing one.

[VasilisThePikachu]

I think it's fine and doesn't really fall under the freeze, since it's not adding a new ghost role, but randomizing the appearance of an existing one.

New pets. While fluff is nice we have enough cargo-obtainable fluff animals and department mascots, to add new animals they must have something interesting like new AI behaviors or spawn in proc gen maps.

I would call this a new department mascot. And it does not add anything interesting

[Carmell0]

Suggestions:
The name “nup nup” or “nip nip” would be funnier
Splash text saying “engage in a rivalry with pun pun”
Sometimes pun and yip spawn together. Sometimes both are at the bar, or maybe make it so yip spawns in the maints bar.

[CatMagic1]

I would argue that this is cool and yall are using TOO much logic to decide on funny lizard bartender

[UbaserB]

Suggestions:
The name “nup nup” or “nip nip” would be funnier
Splash text saying “engage in a rivalry with pun pun”
Sometimes pun and yip spawn together. Sometimes both are at the bar, or maybe make it so yip spawns in the maints bar.

i agree with this

[Hmeister-real]

no explanation, just closed? This is a sad day

[VasilisThePikachu]

no explanation, just closed? This is a sad day

they got repo banned

[Hmeister-real]

no explanation, just closed? This is a sad day

they got repo banned

oh... what for?

[FairlySadPanda]

ok hear me out

[deltanedas]

ok hear me out

april 1 pun pun replacement

[Xman0613]

no explanation, just closed? This is a sad day

they got repo banned

wait why did they get repo banned?

[Jezithyr]

Reopened since this author's repoban was in error. (The ban was made due to a misunderstood reference to the stonewall riots in an april fools PR)

[gitjubx]

no explanation, just closed? This is a sad day

they got repo banned

wait why did they get repo banned?

he censort the LGBTQ capes and made a joke about it beeing funny to censoring it or such...then wiggled himself out so like punch then apologize and everything is fine!

[PolterTzi]

no explanation, just closed? This is a sad day

they got repo banned

wait why did they get repo banned?

he censort the LGBTQ capes and made a joke about it beeing funny to censoring it or such...then wiggled himself out so like punch then apologize and everything is fine!

I censored them in the media preview of the april fools PR that was meant to add them to riot gear (since "pride was a riot" and all that).
I very much did not intend to censor them in game.
The censorship was admittedly not a good idea and that's on me.

[metalgearsloth]

#25982 is a better approach to this.

[PolterTzi]

I don't really agree that it's strictly better, but there's little point in me arguing when it's still frozen anyway.