Canisters [ Continuation of clement-or #2544 ] #2628
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update forks
…tation-14 into more-canisters
…tation-14 into more-canisters
…tation-14 into more-canisters
…station-14 into more-canisters-ext
…t interdependencies for no reason whatsoever)
|
Seems fine, I approve |
20kdc
commented
Nov 27, 2020
There was a problem hiding this comment.
This was supposed to be visible on the (1/2) commit, but I failed
#2628 (comment)
|
Attempted to leave an additional note on the commits, failed hilariously |
Content.Server/GameObjects/Components/Atmos/GasCanisterComponent.cs
Outdated
Show resolved
Hide resolved
Content.Server/GameObjects/Components/Atmos/GasCanisterComponent.cs
Outdated
Show resolved
Hide resolved
Content.Server/GameObjects/Components/Atmos/GasCanisterComponent.cs
Outdated
Show resolved
Hide resolved
|
Aside from these few nitpicks, this seems fine to merge. It still seems to be missing a feature to fill gas tank using canisters, but that can be added in a future PR if you want. Up to you. |
PJB3005
reviewed
Nov 28, 2020
Content.Client/GameObjects/Components/Atmos/GasCanisterWindow.cs
Outdated
Show resolved
Hide resolved
Content.Client/GameObjects/Components/Atmos/GasCanisterWindow.cs
Outdated
Show resolved
Hide resolved
Content.Client/GameObjects/Components/Atmos/GasCanisterWindow.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: Pieter-Jan Briers <pieterjan.briers@gmail.com>
PJB3005
reviewed
Nov 29, 2020
PJB3005
reviewed
Nov 29, 2020
Content.Server/GameObjects/Components/Atmos/GasCanisterComponent.cs
Outdated
Show resolved
Hide resolved
|
Might wanna fix this for windows. |
Look at the test that failed |
|
The failing test is ReconnectTest, unrelated to this PR, correct? |
|
Yes |
…rated (hopefully)
gradientvera
suggested changes
Dec 8, 2020
Content.Client/GameObjects/Components/Atmos/GasCanisterVisualizer.cs
Outdated
Show resolved
Hide resolved
Content.Client/GameObjects/Components/Atmos/GasCanisterVisualizer.cs
Outdated
Show resolved
Hide resolved
Content.Client/GameObjects/Components/Atmos/GasCanisterWindow.cs
Outdated
Show resolved
Hide resolved
Content.Client/GameObjects/Components/Atmos/GasCanisterWindow.cs
Outdated
Show resolved
Hide resolved
Content.Client/GameObjects/Components/Atmos/GasCanisterWindow.cs
Outdated
Show resolved
Hide resolved
Content.Client/GameObjects/Components/Atmos/GasCanisterWindow.cs
Outdated
Show resolved
Hide resolved
Content.Server/GameObjects/Components/Atmos/GasCanisterComponent.cs
Outdated
Show resolved
Hide resolved
…t [Updates for TileAtmosphere.Invalidate]
gradientvera
approved these changes
Dec 8, 2020
|
Thanks for all the big work, it was my first big PR and I didn't have a chance to complete it due to health issues |
DoutorWhite
pushed a commit
to rbertoche/space-station-14
that referenced
this pull request
Jun 26, 2024
Fildrance
pushed a commit
to Fildrance/space-station-14
that referenced
this pull request
Dec 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm attempting to maintain this PR.
Note that if clement-or (author of most of the commits here in #2544 ) wants to instead continue it, they can.
The added commits so far are just to handle the "obvious" issues that appeared during my testing of the PR.
Under the circumstances, I'd consider this not-draft, as pipenet port connections were implemented by clement-or contrary to the description of their PR.
Transfer of air between canisters works but seems to act "non-obviously" in regards to the mechanics of transfer to/from the PipeNet.
Something that doesn't seem to be present at all is transfer to/from tank items, but this could be delayed for a future PR - having a way to use PipeNet at all is a start in getting it going.