Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Favorites tab for the construction menu #26347

Merged

Conversation

Arteben
Copy link
Contributor

@Arteben Arteben commented Mar 22, 2024

About the PR

This PR adds a new 'Favorites' tab where you can add recipes by collecting them from various tabs into one for your convenience. A button is added in the top right corner to delete or add recipes. Additionally, there's a slight change in resetting text from the search bar. When a new tab is selected, the text and, accordingly, the search are reset.

Technical details

Simple changes, only for the construction window UI.

Media

image

video.mp4
  • I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Changelog

🆑

  • add: Added favorite tab for construction!

@github-actions github-actions bot added the Changes: UI Changes: Might require knowledge of UI design or code. label Mar 22, 2024
@EmoGarbage404
Copy link
Member

it's kind of annoying that it doesn't make any attempt to save the actual favorites list across sessions.

@Arteben
Copy link
Contributor Author

Arteben commented Mar 25, 2024

it's kind of annoying that it doesn't make any attempt to save the actual favorites list across sessions.

I felt like there wasn't enough favorites, even within one session. I've implemented them. It might be possible between sessions, but for now, it's too difficult for me.

@Arteben Arteben requested a review from metalgearsloth March 26, 2024 19:58
@github-actions github-actions bot added the S: Needs Review Status: Requires additional reviews before being fully accepted label Mar 26, 2024
@metalgearsloth metalgearsloth enabled auto-merge (squash) June 29, 2024 04:07
@metalgearsloth metalgearsloth merged commit 881c232 into space-wizards:master Jun 29, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: UI Changes: Might require knowledge of UI design or code. S: Needs Review Status: Requires additional reviews before being fully accepted
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants