Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Traitor Deathmatch #2719

Merged
merged 10 commits into from
Dec 13, 2020
Merged

Traitor Deathmatch #2719

merged 10 commits into from
Dec 13, 2020

Conversation

20kdc
Copy link
Contributor

@20kdc 20kdc commented Dec 7, 2020

Note that I'm not sure this is really sufficiently finished, so I'm marking as a draft PR.

@20kdc 20kdc marked this pull request as draft December 7, 2020 20:16
@DrSmugleaf DrSmugleaf added the T: New Feature Type: New feature or content, or extending existing content label Dec 8, 2020
@20kdc 20kdc changed the title Traitor Deathmatch [Draft] Traitor Deathmatch Dec 9, 2020
@20kdc
Copy link
Contributor Author

20kdc commented Dec 9, 2020

Making not-draft. The gamemode runs and @Tomeno wanted me to make it non-draft because of that.
There's also a better sprite for the redemption machine (an edit by Tomeno) but copyright/license fields need to be worked out for it.

@20kdc 20kdc marked this pull request as ready for review December 9, 2020 15:08
@20kdc
Copy link
Contributor Author

20kdc commented Dec 9, 2020

...and then merge conflicts came along

@DrSmugleaf DrSmugleaf added the Changes: Map Changes: Might require knowledge of mapping. label Dec 9, 2020
@20kdc
Copy link
Contributor Author

20kdc commented Dec 9, 2020

Ok, so in order to prevent further alterations from making even more of a mess, I am going to be moving the "refactor" parts of this into a separate PR, and then. As such, the merge conflicts (and thus do-not-merge status) will remain until I've dealt with that.

@20kdc
Copy link
Contributor Author

20kdc commented Dec 11, 2020

The TraitorDM PR is now operational again.

Copy link
Contributor

@gradientvera gradientvera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some nitpicks, other than that LGTM!

@gradientvera gradientvera merged commit fd0df9a into space-wizards:master Dec 13, 2020
Fildrance pushed a commit to Fildrance/space-station-14 that referenced this pull request Dec 2, 2024
Co-authored-by: NotSoDamn <75203942+NotSoDana@users.noreply.github.com>
Co-authored-by: mhamster <81412348+mhamsterr@users.noreply.github.com>
Co-authored-by: lapatison <100279397+lapatison@users.noreply.github.com>
Kirus59 pushed a commit to Kirus59/space-station-14 that referenced this pull request Dec 29, 2024
Co-authored-by: NotSoDamn <75203942+NotSoDana@users.noreply.github.com>
Co-authored-by: mhamster <81412348+mhamsterr@users.noreply.github.com>
Co-authored-by: lapatison <100279397+lapatison@users.noreply.github.com>
stalengd pushed a commit to SerbiaStrong-220/space-station-14 that referenced this pull request Dec 30, 2024
Co-authored-by: NotSoDamn <75203942+NotSoDana@users.noreply.github.com>
Co-authored-by: lapatison <100279397+lapatison@users.noreply.github.com>

* fix locale (space-wizards#2688)

* Fix morgue.ftl locale (space-wizards#2707)

* Translate Upstream space-wizards#2718 (space-wizards#2719)

Co-authored-by: NotSoDamn <75203942+NotSoDana@users.noreply.github.com>
Co-authored-by: mhamster <81412348+mhamsterr@users.noreply.github.com>
Co-authored-by: lapatison <100279397+lapatison@users.noreply.github.com>

* fix arrivals gender locale (space-wizards#2723)

* fix law locale (space-wizards#2734)

* Фикс законов боргов. (space-wizards#2754)

* replace zzz (space-wizards#2758)

* Translate Upstream space-wizards#2785 (space-wizards#2797)

Co-authored-by: lapatison <lapatisonsocial@gmail.com>
Co-authored-by: lzk <124214523+lzk228@users.noreply.github.com>
Co-authored-by: cfif126 <94059374+cfif126@users.noreply.github.com>

* translate borer names (space-wizards#2835)

* Перевод Upstream space-wizards#2830  (space-wizards#2836)

Co-authored-by: lapatison <lapatisonsocial@gmail.com>
Co-authored-by: NotSoDamn <75203942+NotSoDana@users.noreply.github.com>
Co-authored-by: lzk <124214523+lzk228@users.noreply.github.com>
Co-authored-by: cfif126 <94059374+cfif126@users.noreply.github.com>

* Translate Upstream space-wizards#2748 (space-wizards#2837)

Co-authored-by: lapatison <100279397+lapatison@users.noreply.github.com>

* duplicates fix

* duplicates fix 2

* duplicates fix 3

* gender fix

* change timers desc

* delete corvax locale

* delete corvax comment

* SS220 antimov law

* Lost soul tweaks

* change comments

---------

Co-authored-by: lzk <124214523+lzk228@users.noreply.github.com>
Co-authored-by: NotSoDamn <75203942+NotSoDana@users.noreply.github.com>
Co-authored-by: lapatison <100279397+lapatison@users.noreply.github.com>
Co-authored-by: mhamster <81412348+mhamsterr@users.noreply.github.com>
Co-authored-by: Kill_Me_I_Noobs <118206719+Vonsant@users.noreply.github.com>
Co-authored-by: lapatison <lapatisonsocial@gmail.com>
Co-authored-by: cfif126 <94059374+cfif126@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: Map Changes: Might require knowledge of mapping. T: New Feature Type: New feature or content, or extending existing content
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants