Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds more monkey compatibility to existing outfits #27542

Closed
wants to merge 3 commits into from

Conversation

Mith-randalf
Copy link
Contributor

@Mith-randalf Mith-randalf commented Apr 30, 2024

About the PR

Added some sprites to allow monkeys to wear the following:
Kimono
Ninja Jumpsuit
NT paramedic Jumpsuit
Web Jumpsuit
Emergency Firesuit
Bomb Suit
Monkey Suit
Emergency EVA Suit

I've also added assets and rsi meta stuff for colored jumpsuits and jumpskirts, including prisoner, but I'm fairly sure those don't display due to how they apply colour (seems to lock in or override species state, so its always human), so only works when they're manually set in varedit. This is something I've tried to fix and can't, but with the assets in, it'll work as soon as someone changes how that works.

Why / Balance

I'm a monkey main. The main thing was the emergency eva suit which genuinely would be useful for monkies to be able to use. Plus allowing the monkey to wear a monkey suit is conceptually funny.

Media

V video V
https://www.dropbox.com/scl/fi/6nwzoseytirc5n7z1lh4o/2024-04-30-18-53-23.mp4?rlkey=2o298xioodmxkua2wzj64w7hl&st=7589qzsp&dl=0

  • I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Changelog

🆑 mith

  • add: Following a Species Action Lawsuit, more outfits are now monkey-compatible, including emergency EVA and fire suits.

@github-actions github-actions bot added Changes: No C# Changes: Requires no C# knowledge to review or fix this item. Changes: Sprites Changes: Might require knowledge of spriting or visual design. labels Apr 30, 2024
Copy link
Contributor

github-actions bot commented Apr 30, 2024

RSI Diff Bot; head commit c0e7aef merging into c3a0ba9
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/Clothing/OuterClothing/Suits/bombsuit.rsi

State Old New Status
equipped-OUTERCLOTHING-monkey Added

Resources/Textures/Clothing/OuterClothing/Suits/eva_emergency.rsi

State Old New Status
equipped-OUTERCLOTHING-monkey Added

Resources/Textures/Clothing/OuterClothing/Suits/fire.rsi

State Old New Status
equipped-OUTERCLOTHING-monkey Added

Resources/Textures/Clothing/OuterClothing/Suits/monkey.rsi

State Old New Status
equipped-OUTERCLOTHING-monkey Added

Resources/Textures/Clothing/Uniforms/Jumpskirt/color.rsi

State Old New Status
equipped-INNERCLOTHING-monkey Added
prisoner-equipped-INNERCLOTHING-monkey Added
trinkets-equipped-INNERCLOTHING-monkey Added

Resources/Textures/Clothing/Uniforms/Jumpsuit/color.rsi

State Old New Status
equipped-INNERCLOTHING-monkey Added
prisoner-equipped-INNERCLOTHING-monkey Added
trinkets-equipped-INNERCLOTHING-monkey Added

Resources/Textures/Clothing/Uniforms/Jumpsuit/kimono.rsi

State Old New Status
equipped-INNERCLOTHING-monkey Added

Resources/Textures/Clothing/Uniforms/Jumpsuit/ninja.rsi

State Old New Status
equipped-INNERCLOTHING-monkey Added

Resources/Textures/Clothing/Uniforms/Jumpsuit/paramedic_nt.rsi

State Old New Status
equipped-INNERCLOTHING-monkey Added

Resources/Textures/Clothing/Uniforms/Jumpsuit/web.rsi

State Old New Status
equipped-INNERCLOTHING-monkey Added

Edit: diff updated after c0e7aef

@Dutch-VanDerLinde
Copy link
Contributor

CL is broken you need the 🆑 emoji

@UbaserB
Copy link
Member

UbaserB commented Apr 30, 2024

I’m pretty sure this is frozen by #8524

@Mith-randalf
Copy link
Contributor Author

I’m pretty sure this is frozen by #8524

I guess it comes down to whether this falls under "This freeze wont apply for maintaining current variants (like monkey suits)."

but I'm fine with it going on ice til later

@Dutch-VanDerLinde
Copy link
Contributor

also says if the sprite can't be displacement mapped

@UbaserB
Copy link
Member

UbaserB commented Apr 30, 2024

also says if the sprite can't be displacement mapped

from what i heard, all monkey clothing sprites are to be eventually displacement mapped, its just no one has done it yet.

@Dutch-VanDerLinde
Copy link
Contributor

also says if the sprite can't be displacement mapped

from what i heard, all monkey clothing sprites are to be eventually displacement mapped, its just no one has done it yet.

it means like if the sprite is impossible to displacement map

@IProduceWidgets
Copy link
Contributor

My understanding was that displacement maps were intended to reduce the burden of needing to make lots of sprites for non-standard species, not that it would mean refusing custom sprites for those species provided the custom sprites were better than a displacement map.

@metalgearsloth
Copy link
Contributor

This is new variants, not modifications, and maintaining monkeys is already bad enough so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: No C# Changes: Requires no C# knowledge to review or fix this item. Changes: Sprites Changes: Might require knowledge of spriting or visual design.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants