Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gives Mediborg the Medical Hud #28391

Merged
merged 4 commits into from
Jun 1, 2024
Merged

Conversation

Cojoke-dot
Copy link
Contributor

About the PR

Title

Why / Balance

I assumed that mediborgs already had the hud when making #27875, as the hud is used to help people in need.

Technical details

yml changes

Media

image

  • I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Breaking changes

Changelog

🆑

  • add: Medical Borgs now have medical huds

@github-actions github-actions bot added the Changes: No C# Changes: Requires no C# knowledge to review or fix this item. label May 29, 2024
Copy link
Member

@AJCM-git AJCM-git left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay this is starting to pile up, just make a new parent prototype with the ShowHealthBars and ShowHealthIcons comps configured and make every entity prototype with the following pattern inherit it (prots can have multiple parents)

  - type: ShowHealthBars
    damageContainers:
    - Biological
  - type: ShowHealthIcons
    damageContainers: 
    - Biological

@AJCM-git AJCM-git added the S: Awaiting Changes Status: Changes are required before another review can happen label May 30, 2024
@Cojoke-dot
Copy link
Contributor Author

Meh... Don't know what's causing the GitHub error but I did the requested change. I think I set all the items that needed the parent but I'm not sure, tell me if you notice anything I missed.

@Cojoke-dot Cojoke-dot requested a review from AJCM-git May 30, 2024 22:44
@github-actions github-actions bot added S: Needs Review Status: Requires additional reviews before being fully accepted and removed S: Awaiting Changes Status: Changes are required before another review can happen labels May 30, 2024
Copy link
Member

@AJCM-git AJCM-git left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are the only ones that need to be parented to ShowMedicalIcons:
MobMedibot, ClothingEyesHudMedical, ClothingEyesHudMedOnion (prob should just be parented to the base hud), ClothingEyesHudMedOnionBeer (same), ClothingEyesHudMedSec, ClothingEyesHudMultiversal (only partially cuz it overrides ShowHealthBars) , ClothingEyesHudOmni (same).

@AJCM-git AJCM-git added S: Awaiting Changes Status: Changes are required before another review can happen and removed S: Needs Review Status: Requires additional reviews before being fully accepted labels May 31, 2024
@AJCM-git AJCM-git mentioned this pull request May 31, 2024
@Cojoke-dot
Copy link
Contributor Author

Ok, all of the objects are parented that you requested, plus BorgChassisMedical because that's the main point of the pr. I believe the only thing I missed last time was MobMedibot.

@Cojoke-dot Cojoke-dot requested a review from AJCM-git June 1, 2024 04:25
@github-actions github-actions bot added S: Needs Review Status: Requires additional reviews before being fully accepted and removed S: Awaiting Changes Status: Changes are required before another review can happen labels Jun 1, 2024
@AJCM-git AJCM-git merged commit cbba09a into space-wizards:master Jun 1, 2024
12 checks passed
@Cojoke-dot Cojoke-dot deleted the MediBorgHud branch June 2, 2024 08:38
marboww added a commit to marboww/space-station-14-wiz that referenced this pull request Jun 16, 2024
metalgearsloth pushed a commit that referenced this pull request Jul 25, 2024
* Update borg_chassis.yml

* Update borg_chassis.yml

* fix

* Removing unnecessary components and adapting changes (#28391) for the syndicate

---------

Co-authored-by: Ed <96445749+TheShuEd@users.noreply.github.com>
themias pushed a commit to themias/space-station-14 that referenced this pull request Aug 9, 2024
* Update borg_chassis.yml

* Update borg_chassis.yml

* fix

* Removing unnecessary components and adapting changes (space-wizards#28391) for the syndicate

---------

Co-authored-by: Ed <96445749+TheShuEd@users.noreply.github.com>
Baa14453 pushed a commit to Baa14453/space-station-14 that referenced this pull request Oct 19, 2024
* Update borg_chassis.yml

* Update borg_chassis.yml

* fix

* Removing unnecessary components and adapting changes (space-wizards#28391) for the syndicate

---------

Co-authored-by: Ed <96445749+TheShuEd@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: No C# Changes: Requires no C# knowledge to review or fix this item. S: Needs Review Status: Requires additional reviews before being fully accepted
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants