Makes EventRole Ids properly set ID names. #28958
Open
+68
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
S: Needs Review
|
why does the moth have hte identity Felana Leander when the id card is Specialist Chameleon |
|
Weirdness because randomizeName isn't set to false on ERT/CBURN meaning they have their name randomized twice, which I should probably fix here. |
|
Moved the system to server, and changed it to activate on mind added (Couldn't find a way to make sure it only activates after it applies the name and everything except that) |
metalgearsloth
requested changes
Aug 11, 2024
metalgearsloth
added
S: Awaiting Changes
slarticodefast
requested changes
Nov 4, 2024
SlamBamActionman
added
the
S: Untriaged
SlamBamActionman
added
P3: Standard
SlamBamActionman
added
A: General Interactions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the PR
Event roles like ERT or shuttle roles now have their ids set their name on the card.
Why / Balance
So you know who the card belonged to, and so it shows up when opening the PDA.
Technical details
New component: ID bind that activates when a mind is added then removes itself.
Media
id.binding.mov
Breaking changes
No?
Changelog
no cl just flavor