Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Nukie Song "Last Call" #30047

Closed
wants to merge 3 commits into from
Closed

Conversation

he1acdvv
Copy link
Contributor

This is my first PR that i've done single-handedly. I'm sincerely sorry if i got something wrong.

  ❗ ❗ ❗ 

About the PR

Added a new Nuke Detonation Song. (again)

Why / Balance

I felt like making a new nuke ost again.

Technical details

I went to the wizards of the forest, who gave me divine inspiration.

Media

last_call.mp4
  • I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Breaking changes

Changelog

🆑 mryikes

  • add: New Nuke Detonation Song "Last Call".

@github-actions github-actions bot added the Changes: No C# Changes: Requires no C# knowledge to review or fix this item. label Jul 14, 2024
Copy link
Contributor

@PursuitInAshes PursuitInAshes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approval just indicates it is implemented correctly. Good job on your first PR by yourself.

@he1acdvv
Copy link
Contributor Author

Approval just indicates it is implemented correctly. Good job on your first PR by yourself.

phew.. Thank you! : D

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah no i'm sorry, it should be working fine now.

@TeenSarlacc
Copy link

album cover goes hard

@he1acdvv
Copy link
Contributor Author

album cover goes hard

made it myself

@XxSWAG-MASTER-OVERLORDxX

bro cooked, and its straight fire.

@ps3moira
Copy link
Contributor

After relistening to all 4 nukie songs and listening to this, this song doesn't fit on the same level as the other songs we have. Especially at 0:40 it just doesn't fit and sounds like it was meant for a different game.

@he1acdvv
Copy link
Contributor Author

After relistening to all 4 nukie songs and listening to this, this song doesn't fit on the same level as the other songs we have. Especially at 0:40 it just doesn't fit and sounds like it was meant for a different game.

Not all of the songs are supposed to sound alike. I tried to bring a little bit of a new sound into the circle.
After all, it's really a matter of personal preference, but it's never a bad thing to try new stuff, is it? Some change here and there can be good.

@ps3moira
Copy link
Contributor

After relistening to all 4 nukie songs and listening to this, this song doesn't fit on the same level as the other songs we have. Especially at 0:40 it just doesn't fit and sounds like it was meant for a different game.

Not all of the songs are supposed to sound alike. I tried to bring a little bit of a new sound into the circle. After all, it's really a matter of personal preference, but it's never a bad thing to try new stuff, is it? Some change here and there can be good.

The point of nuke countdown music is that it sounds like a countdown and that there's a rush to disarm, this song however doesn't do that all that well (but I can see the hints of elements inspired from other songs) and sounds more like a space invaders type of song. I want to hammer home that this isn't unsalvageable and it's sound can be improved upon to fit the theme of nukies going on station murking crew, the nuke counting down and the station sounding like it's going to blow up.

@he1acdvv
Copy link
Contributor Author

After relistening to all 4 nukie songs and listening to this, this song doesn't fit on the same level as the other songs we have. Especially at 0:40 it just doesn't fit and sounds like it was meant for a different game.

Not all of the songs are supposed to sound alike. I tried to bring a little bit of a new sound into the circle. After all, it's really a matter of personal preference, but it's never a bad thing to try new stuff, is it? Some change here and there can be good.

The point of nuke countdown music is that it sounds like a countdown and that there's a rush to disarm, this song however doesn't do that all that well (but I can see the hints of elements inspired from other songs) and sounds more like a space invaders type of song. I want to hammer home that this isn't unsalvageable and it's sound can be improved upon to fit the theme of nukies going on station murking crew, the nuke counting down and the station sounding like it's going to blow up.

Well, there are still elements of that present, i just wanted for it to have a more hopeful feel. I've done the previous track "Clearly Nuclear" the way you just described it.

@he1acdvv
Copy link
Contributor Author

Well, i personally do believe this can add to SS14's atmosphere. It's up to the people (and maintainers) to decide whether this goes in or not. If the community doesn't like that much, well.. We can always revert it.

@he1acdvv

This comment was marked as off-topic.

@VasilisThePikachu VasilisThePikachu added the S: Frozen Status: Affects a game area that's frozen. Check "Current Freezes" in the Issues tab. label Jul 22, 2024
@VasilisThePikachu
Copy link
Member

VasilisThePikachu commented Jul 22, 2024

Hey sorry for the delay. Unfortunately currently there is a freeze on new music of any kind until a streaming option is available. This freeze was done since music files increase the file size of the game by quite a bit (you can read more about frozen and restricted items on this issue #8524)

Granted the freeze page could have been better explaining that all music was frozen so I apologize for that. I fixed that now.

You are free to request this PR to be reopened once the freeze prerequisite has been met. Once again I apologize.

@he1acdvv
Copy link
Contributor Author

3 mb of files........

at least let's hope the solution won't take a year or so

@he1acdvv
Copy link
Contributor Author

a bit bummed out since i did ask some people whether nuke songs fall under the music freeze and i was told - apparently not.

@a-person5660

This comment was marked as spam.

@Simyon264
Copy link
Contributor

#29345 was merged as well by sloth. Do nukie songs count too? I'd really love more nuke detonation songs, as those events are kind of rare and not as big as lobby songs.

@VasilisThePikachu
Copy link
Member

VasilisThePikachu commented Jul 22, 2024

As far as I'm aware. We can't accept new songs of any kind due to the size they will take on the repo/the final game client. And in general as described in the freeze doc. "We have too many songs" (yes 3mb can be a lot)

Maybe sloth missed it, or I'm missing out a point myself. I had tried asking for maintainer opinions about this pr and I got silence. So I'm working on my own discretion as a maintainer.

@Simyon264
Copy link
Contributor

I had tried asking for maintainer opinions about this pr and I got silence.

Could you try again? I would really love to see this in the game, especially because it is custom made.

@he1acdvv
Copy link
Contributor Author

honestly -- don't merge this since i've made an improved version anyways.

i'll make a pr when the time's right

@VasilisThePikachu
Copy link
Member

VasilisThePikachu commented Jul 23, 2024

Heya, I this time got some opinions from some of the maintainer team and the conclusion is that this was correctly marked as frozen.

#29345 was merged as well by sloth.

This is cause this was the music used for the trailer, and we thought it would be explainable for this reason.
Maintainers may skip over a freeze in certain cases. The song being used in the trailer and technically being the "Space Station 14" song gave it some reasons.

3 mb of files........

It may not seem a lot, but 3 mb can be quite a lot. Not everyone has an amazing internet. And also merging one song will result in a bunch of other pull requests being made and inflate the game of the final build of the game the players get served. We would like to keep file size as small as possible as of currently till we have better systems in place.

I apologize once again for this. You are more than welcome to make a new pull request once this freeze is lifted.

@he1acdvv
Copy link
Contributor Author

goobstation new nukie song it is then

@he1acdvv he1acdvv deleted the Musueek branch July 23, 2024 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: No C# Changes: Requires no C# knowledge to review or fix this item. S: Frozen Status: Affects a game area that's frozen. Check "Current Freezes" in the Issues tab.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants