-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Nukie Song "Last Call" #30047
New Nukie Song "Last Call" #30047
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approval just indicates it is implemented correctly. Good job on your first PR by yourself.
phew.. Thank you! : D |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah no i'm sorry, it should be working fine now.
album cover goes hard |
made it myself |
bro cooked, and its straight fire. |
After relistening to all 4 nukie songs and listening to this, this song doesn't fit on the same level as the other songs we have. Especially at 0:40 it just doesn't fit and sounds like it was meant for a different game. |
Not all of the songs are supposed to sound alike. I tried to bring a little bit of a new sound into the circle. |
The point of nuke countdown music is that it sounds like a countdown and that there's a rush to disarm, this song however doesn't do that all that well (but I can see the hints of elements inspired from other songs) and sounds more like a space invaders type of song. I want to hammer home that this isn't unsalvageable and it's sound can be improved upon to fit the theme of nukies going on station murking crew, the nuke counting down and the station sounding like it's going to blow up. |
Well, there are still elements of that present, i just wanted for it to have a more hopeful feel. I've done the previous track "Clearly Nuclear" the way you just described it. |
Well, i personally do believe this can add to SS14's atmosphere. It's up to the people (and maintainers) to decide whether this goes in or not. If the community doesn't like that much, well.. We can always revert it. |
This comment was marked as off-topic.
This comment was marked as off-topic.
Hey sorry for the delay. Unfortunately currently there is a freeze on new music of any kind until a streaming option is available. This freeze was done since music files increase the file size of the game by quite a bit (you can read more about frozen and restricted items on this issue #8524) Granted the freeze page could have been better explaining that all music was frozen so I apologize for that. I fixed that now. You are free to request this PR to be reopened once the freeze prerequisite has been met. Once again I apologize. |
3 mb of files........ at least let's hope the solution won't take a year or so |
a bit bummed out since i did ask some people whether nuke songs fall under the music freeze and i was told - apparently not. |
This comment was marked as spam.
This comment was marked as spam.
#29345 was merged as well by sloth. Do nukie songs count too? I'd really love more nuke detonation songs, as those events are kind of rare and not as big as lobby songs. |
As far as I'm aware. We can't accept new songs of any kind due to the size they will take on the repo/the final game client. And in general as described in the freeze doc. "We have too many songs" (yes 3mb can be a lot) Maybe sloth missed it, or I'm missing out a point myself. I had tried asking for maintainer opinions about this pr and I got silence. So I'm working on my own discretion as a maintainer. |
Could you try again? I would really love to see this in the game, especially because it is custom made. |
honestly -- don't merge this since i've made an improved version anyways. i'll make a pr when the time's right |
Heya, I this time got some opinions from some of the maintainer team and the conclusion is that this was correctly marked as frozen.
This is cause this was the music used for the trailer, and we thought it would be explainable for this reason.
It may not seem a lot, but 3 mb can be quite a lot. Not everyone has an amazing internet. And also merging one song will result in a bunch of other pull requests being made and inflate the game of the final build of the game the players get served. We would like to keep file size as small as possible as of currently till we have better systems in place. I apologize once again for this. You are more than welcome to make a new pull request once this freeze is lifted. |
goobstation new nukie song it is then |
This is my first PR that i've done single-handedly. I'm sincerely sorry if i got something wrong.
About the PR
Added a new Nuke Detonation Song. (again)
Why / Balance
I felt like making a new nuke ost again.
Technical details
I went to the wizards of the forest, who gave me divine inspiration.
Media
last_call.mp4
Breaking changes
Changelog
🆑 mryikes