give nukie reinforcements full operative gear

[Ilya246]

About the PR

makes nukie reinforcements spawn with full nukie gear minus uplink, also gives them normal operative names

also gives them a free normal toy fish

(additionally removes random double space in uplink catalog)

Why / Balance

i believe 35 TC is way too much for a reinforcement with no gear, the opportunity cost is extreme, so this partially balances it out

discord seemed to agree with me

35 TC reinfs have been in the game for some time now so i would suppose we can use the down/upvotes on this PR as a good metric of what people think about this

why toy fish? absolutely necessary

Media

see media in Goob-Station/Goob-Station#383

updated uplink preview: #30173 (comment)

compiled and tested this PR specifically too

• I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Changelog

🆑

• tweak: Nuclear operative reinforcements now come with full nuclear operative gear (and a toy carp) at no additional cost.
• tweak: Nuclear operative reinforcements now get nuclear operative names.

[Plykiya]

Going by the media, it gave them the name Agent Oscar. That needs to be changed.

"Agent" is reserved for the medic
"Operative" is the generic unit

Update the thumbnail icon that the reinforcement thing uses to better reflect they are fully equipped in a blood-red and are a proper nuclear operative

[Sinis-Boop]

Will make the 35 tc cost actually worth it

[Ilya246]

Going by the media, it gave them the name Agent Oscar. That needs to be changed.

"Agent" is reserved for the medic "Operative" is the generic unit

Update the thumbnail icon that the reinforcement thing uses to better reflect they are fully equipped in a blood-red

loneops can have both agent and operative, i based it off that
thumbnail needs minor sprite editing work but i guess i will

[Plykiya]

Going by the media, it gave them the name Agent Oscar. That needs to be changed.
"Agent" is reserved for the medic "Operative" is the generic unit
Update the thumbnail icon that the reinforcement thing uses to better reflect they are fully equipped in a blood-red

loneops can have both agent and operative, i based it off that thumbnail needs spritework but i guess i will

Good thing they're not a lone op anymore! Also I'm pretty sure that overriding gear like that doesn't work. You'll have to change how you do it. I'm pretty certain(???) it'll just cause the regular nukie ops/agents to drop their TC uplinks onto the floor on spawn because their pocket2 slot is already occupied with that plushie carp. I ran into this same issue with duplicating backpack slots or starting with multiple pairs of glasses in hand.

[Ilya246]

Good thing they're not a lone op anymore! Also I'm pretty sure that overriding gear like that doesn't work. I think it'll just cause the regular nukie ops/agents to drop their TC uplinks on spawn because their pocket2 slot is already occupied with a plushie. I ran into this same issue with duplicating backpack slots or starting with multiple pairs of glasses in hand.

i've tested it and it does work, though will re-test it later to be absolutely sure
and fine i'll rename them to Operative-only since names kinda matter in the actual nukie team

[Plykiya]

Thanks, I'll update #29899 to reflect it if there's different behavior depending on what slot gets duplicated. Apparently the behavior is hard to duplicate locally according to Errant, so you may need to try a release build or something like that. Dunno, godspeed.

[Ilya246]

Thanks, I'll update #29899 to reflect it if there's different behavior depending on what slot gets duplicated. Apparently the behavior is hard to duplicate locally according to Errant, so you may need to try a release build or something like that. Dunno, godspeed.

nothing gets dropped for either outfit

[Ilya246]

new preview sprite

meme version holding a fish, will use for real only with maintainer approval as this could be catastrophic for the economy (and potentially misleading about the operative's gear)

[github-actions]

RSI Diff Bot; head commit 773d717 merging into d1ecd84
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/Objects/Devices/communication.rsi

State	Old	New	Status
old-radio-nukeop			Added

Edit: diff updated after 773d717

[Plykiya]

Kindly looks goofy without the helmet on, it's a bit horrifying how bald they are

[Ilya246]

Kindly looks goofy without the helmet on, it's a bit horrifying how bald they are

they're supposed to look scary in the advertisement*

*product may not look as advertised

[metalgearsloth]

Can you provide a comparison of the price pre-nerf and kitting them up vs with this PR as I don't want to play balance yoyo over this.

[metalgearsloth]

Also obviously plykiya's PR is getting merged first.

[Ilya246]

Can you provide a comparison of the price pre-nerf and kitting them up vs with this PR as I don't want to play balance yoyo over this.

gear comparision

non-purchasable gear gained:

• syndicate PDA with syndie ID and a pen inside (little gameplay effect)
• toy fish

price comparision:

• 8 TC with using nukie lockers
• 11 TC otherwise

Also obviously plykiya's PR is getting merged first.

why, conflicts? i've looked over it and there should only be a few trivial ones

balance-wise it should be fine as the PR affects traitor reinfs while this one affects nukie reinfs

[Graded5]

Putting in my two cents pretty quickly.

The fact that reinforcements dont spawn with syndicate comms is crazy. To add insult to injury loneops just straight up cant buy their reinforcements blood-red encryption keys (last I checked at least). Also having them actually be able to access their ship would be a massive QOL, instead of basically forcing at least one member to buy a agent ID and hand-me-down their old ID.

If (for some reason) its decided to not let reinforcements get a free suit then please at least let them keep the other gear.

[Plykiya]

Putting in my two cents pretty quickly.

The fact that reinforcements dont spawn with syndicate comms is crazy. To add insult to injury loneops just straight up cant buy their reinforcements blood-red encryption keys (last I checked at least). Also having them actually be able to access their ship would be a massive QOL, instead of basically forcing at least one member to buy a agent ID and hand-me-down their old ID.

If (for some reason) its decided to not let reinforcements get a free suit then please at least let them keep the other gear.

I guess they didn't have it because of the locker room on the nukie home planet, but that doesn't apply to loneops, so I guess it's fine to give it to the reinforcements. One less thing for both sets of nukies to worry about.

[github-actions]

This pull request has conflicts, please resolve those before we can evaluate the pull request.

[Plykiya]

Can you provide a comparison of the price pre-nerf and kitting them up vs with this PR as I don't want to play balance yoyo over this.

TC comparison if the nukies have to buy a bloodred for the reinforcement

• Original cost: 16 TC (reinf) + 8 TC (bloodred) = 24 TC (they have enough to buy one more reinf)
• Nerf cost: 35 TC (reinf) + 8 TC (bloodred) = 43 TC (exceeds one nukie's budget)
• Buff cost: 35 TC (reinf) + 0 TC (free bloodred) = 35TC

Best case scenario if someone buys an elite suit and gives the reinforcement their old hardsuit is

• Original cost: 16 TC (reinf) = 16 TC (they have enough to buy one more reinf and a bloodred)
• Nerf cost: 35 TC (reinf) = 35 TC
• Buff cost: 35 TC (reinf) + 0 TC (free bloodred) = 35TC

The 8 TC saved is enough to buy an esword if another nukie chips 3 TC in, which is what nukies will go for a majority of the time. So that's what this buff effectively is, just one more esword on the nukie side. Which I'd say is a pretty fair buff since their total bodycount is still cut in half from what it was originally.

I reviewed all the changes, I'm satisfied with it.

[Plykiya]

lgtm (the code, anyways, balance is another thing)

Maintainers are fine with the balance changes, so we're good.