Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tweak(GunRequiresWield): State the requirement for gun wielding in the description. #30301

Merged
merged 3 commits into from
Jul 24, 2024
Merged

tweak(GunRequiresWield): State the requirement for gun wielding in the description. #30301

merged 3 commits into from
Jul 24, 2024

Conversation

Brandon-Huu
Copy link
Contributor

About the PR

States the requirement for gun wielding in the description.

Why / Balance

Resolves #29316

Technical details

Media

  • I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Before
Screenshot from 2024-07-23 19-21-29

After
Screenshot from 2024-07-23 19-11-29

Breaking changes

Changelog

@github-actions github-actions bot added the S: Needs Review Status: Requires additional reviews before being fully accepted label Jul 24, 2024
deathride58
deathride58 approved these changes Jul 24, 2024
View reviewed changes
Copy link
Member

@deathride58 deathride58 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a fairly straight-forward cosmetic fix for a cosmetic form of jank

@deathride58 deathride58 merged commit c4dcc90 into space-wizards:master Jul 24, 2024
11 checks passed
themias pushed a commit to themias/space-station-14 that referenced this pull request Aug 9, 2024
@Brandon-Huu @themias
tweak(GunRequiresWield): State the requirement for gun wielding in th…
9c743d7 
…e description. (space-wizards#30301)

* https://en.wikipedia.org/wiki/List_of_LASD_deputy_gangs

* https://knock-la.com/tradition-of-violence-lasd-gang-history/

* https://coc.lacounty.gov/deputy-gangs/
Baa14453 pushed a commit to Baa14453/space-station-14 that referenced this pull request Oct 19, 2024
@Brandon-Huu @Baa14453
tweak(GunRequiresWield): State the requirement for gun wielding in th…
415583a 
…e description. (space-wizards#30301)

* https://en.wikipedia.org/wiki/List_of_LASD_deputy_gangs

* https://knock-la.com/tradition-of-violence-lasd-gang-history/

* https://coc.lacounty.gov/deputy-gangs/
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deathride58 deathride58 deathride58 approved these changes

@metalgearsloth metalgearsloth Awaiting requested review from metalgearsloth metalgearsloth is a code owner

Assignees
No one assigned
Labels
S: Needs Review Status: Requires additional reviews before being fully accepted
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

wieldable guns description is kinda lying
2 participants
@Brandon-Huu @deathride58