Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add structural damage taken to a lot of prototypes #30790

Merged
merged 5 commits into from
Sep 4, 2024

Conversation

Ilya246
Copy link
Contributor

@Ilya246 Ilya246 commented Aug 8, 2024

About the PR

adds structural damage to a lot of things, including most machines
gameplay-important entities may include: firelocks, girders, machines, directional windows, planet rock specifically

Why / Balance

i believe expected behavior would be for all of those to take structural, so i consider this a bugfix as this fixes unexpected behavior

Media

not tested

Requirements

  • I have read and I am following the Pull Request Guidelines. I understand that not doing so may get my pr closed at maintainer’s discretion
  • I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Changelog

🆑

  • fix: Fixed many entities not taking structural damage, including girders, firelocks, and machines.

@github-actions github-actions bot added the Changes: No C# Changes: Requires no C# knowledge to review or fix this item. label Aug 8, 2024
@Ilya246
Copy link
Contributor Author

Ilya246 commented Aug 8, 2024

actually same bug seems present in tables and other things, fixing

@Ilya246 Ilya246 changed the title fix girder damage modifier add structural damage taken to a lot of prototypes Aug 8, 2024
@SlamBamActionman SlamBamActionman added the S: Undergoing Maintainer Discussion Status: Currently going through an extended discussion amongst maintainers, as per procedure. label Sep 1, 2024
Copy link
Contributor

github-actions bot commented Sep 1, 2024

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot added the S: Merge Conflict Status: Needs to resolve merge conflicts before it can be accepted label Sep 1, 2024
@github-actions github-actions bot removed the S: Merge Conflict Status: Needs to resolve merge conflicts before it can be accepted label Sep 2, 2024
@SlamBamActionman
Copy link
Member

Hello! I've gone through the items being changed and while it overall looks good, there are some items that need some changes.

Remove structural damage

DefaultStationBeacon
BaseLandMine
BaseLightBulb
BaseTarget 
BaseWeaponTurret
BaseCurtains
Bed
StasisBed
SeatBase
SinkEmpty
HolosignWetFloor
AirSensor
SignalButton
TwoWayLever
WeaponTurretSyndicateBroken

Change damageModifierSet to StructuralMetallicStrong

CrateArtifactContainer (Metallic)
AirlockAssembly (Metallic)
BaseFirelock (Metallic)
FirelockFrame (Metallic)
PlasmaDoor (StrongMetallic)
BlastDoorFrame (Metallic)
ComputerComms (StrongMetallic)
ComputerCloningConsole (StrongMetallic)
CloningPod (StrongMetallic)
FatExtractor (StrongMetallic)
Emitter (StrongMetallic)
AmeController (StrongMetallic)
AmeShielding (StrongMetallic)
BaseAPC (StrongMetallic)
BaseSMES (StrongMetallic)
BaseSubstation (StrongMetallic)
BaseSubstationWall (StrongMetallic)
CargoTelepad (Metallic)

Change damageModifierSet to StructuralMetallic

BaseSecretDoor (Metallic)
BaseSecretDoorAssembly (Metallic)
ShuttersFrame (Metallic)
CryoPod (Metallic)
BaseMachine (Metallic)
SolarTracker (Metallic)
APCFrame (Metallic)
FloorDrain (Metallic)
BaseIntercom (Metallic)
Girder (Metallic) [Already changed in the PR]

Change damageModifierSet to Wood

AltarBase (Metallic)
Mannequin

Additionally, add a Structural damage coefficient to the following damageModifierSets (otherwise those objects take full structural damage):
Wood: 0.5
Metallic: 0.5
Inflatable: 0.25
Electronic: 0.5

@Ilya246
Copy link
Contributor Author

Ilya246 commented Sep 4, 2024

it is done @SlamBamActionman

@SlamBamActionman SlamBamActionman merged commit f0d3b68 into space-wizards:master Sep 4, 2024
11 checks passed
@UbaserB UbaserB removed the S: Undergoing Maintainer Discussion Status: Currently going through an extended discussion amongst maintainers, as per procedure. label Sep 4, 2024
@Ilya246 Ilya246 deleted the fixgirderdamagemod branch September 4, 2024 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: No C# Changes: Requires no C# knowledge to review or fix this item.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants