Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replaces small fans on most shuttles with directional fans. #31495

Merged
merged 1 commit into from
Aug 26, 2024
Merged

Replaces small fans on most shuttles with directional fans. #31495

merged 1 commit into from
Aug 26, 2024

Conversation

QueerNB
Copy link
Contributor

@QueerNB QueerNB commented Aug 26, 2024 •
edited
Loading

About the PR

Replaced Most shuttles except Shittle and Infiltrator

Why / Balance

Was discussed in cartography to replace all the evac shuttles with directional fans: https://discord.com/channels/310555209753690112/771041304108072961/1277483208958541924
Was also told in VC to :godo:

Technical details

NA

Media

NA

Requirements

  • I have read and I am following the Pull Request Guidelines. I understand that not doing so may get my pr closed at maintainer’s discretion
  • I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Breaking changes

Changelog

🆑 CuteBoi

  • fix: Replaced small fans on most shuttles with directional fans.

@github-actions github-actions bot added Changes: No C# Changes: Requires no C# knowledge to review or fix this item. Changes: Map Changes: Might require knowledge of mapping. labels Aug 26, 2024
@Emisse Emisse merged commit 4dc750a into space-wizards:master Aug 26, 2024
12 checks passed
@UbaserB UbaserB mentioned this pull request Aug 28, 2024
Closed
Ilya246 pushed a commit to Ilya246/space-station-14 that referenced this pull request Oct 10, 2024
@Piras314 @github-actions
@PJBot @Mervill @PursuitInAshes @eoineoineoin @PJB3005 @metalgearsloth @themias @IProduceWidgets @Emisse @PopGamer45 @ArtisticRoomba @EmoGarbage404 @deltanedas @TheShuEd @Blackern5000 @ShadowCommander @Brandon-Huu @lzk228 @Spessmann @Moomoobeef @Winkarst-cpu @slarticodefast @QueerNB @12rabbits @Dimastra @JIPDawg @SaphireLattice @Aeshus @stellar-novas @Simyon264
Merge Upstream (space-wizards#538)
dea85a3 
* Update Credits (space-wizards#31409)

Co-authored-by: PJBot <pieterjan.briers+bot@gmail.com>

* Replace obsolete code in GasPortableSystem (space-wizards#31407)

* Change `Resave` Permission Requirement to Host (space-wizards#31397)

ChangePermissionFlagToHost

* Automatic changelog update

* Remove client state from server AirAlarmComponent (space-wizards#31236)

* Remove client state from server AirAlarmComponent

Send information for all connected devices, not just the ones for the
current tab, as attempting to limit this breaks multiple users viewing
the same UI.

Fixes space-wizards#12842

* Send device data as a list, rather than a dictionary

---------

Co-authored-by: Eoin Mcloughlin <helloworld@eoinrul.es>

* Fix ChemVend jugs again (space-wizards#31398)

This re-introduces the dummy entity naming code, originally introduced in space-wizards#29178 and randomly removed by space-wizards#30064 with no technical justification given.

Fixes space-wizards#31373

* Automatic changelog update

* Fix dungeon spawn + ftl overlap (space-wizards#31413)

* Fix dungeon spawn + ftl overlap

* Better fixes

* Automatic changelog update

* Fix firelockedge rotation (space-wizards#31371)

save

* Automatic changelog update

* Update Oasis (space-wizards#31415)

* Cameras and junk

* I forgot to clear my multitool

* Automatic changelog update

* marathon update (space-wizards#31421)

* Give sec cadets jackboots instead of combat boots (space-wizards#31419)

give cadets jackboots

* Automatic changelog update

* meta update (space-wizards#31423)

* Adds the Head of Greytide stamp (space-wizards#30189)

suggested changes from discord discussion, sprite change, add to refactored loot table

* Automatic changelog update

* Verb tweaks (space-wizards#31309)

* Verb tweaks

Remove the LOS check because this is already done above in CanExamine.

* Fix outlines

* import

* Add ContainerComp (space-wizards#31311)

Applies EntProtoId changes upon insertion / removal from container. Can also be useful for borgs / mechs / vehicles in future but atm I just used it for AI.

* Blueprints (space-wizards#31138)

* Blueprints

* Update tables_loot.yml

* doink

* mark as required

* Automatic changelog update

* decouple ItemToggle from PowerCellDraw (space-wizards#31392)

* remove ItemToggle from PowerCellDraw query

* add EntityQuery for resolves, make them all optional

* move integration to ToggleCellDraw

* add ToggleCellDraw to almost every PowerCellDraw prototype

* :trollface:

* :trollface:

* :trollface:

* let it disable on mapinit

* set update time on mapinit, make borg power logic consistent now

* :trollface:

---------

Co-authored-by: deltanedas <@deltanedas:kde.org>

* Automatic changelog update

* Power stuff (space-wizards#31314)

* Power stuff

- Add shared IsPowered
- Add shared ResolveApc
- Move PowerChangedEvent to shared for now
- Add SlimPoweredLight that actually functions how you'd expect a PoweredLight to function it id didn't have a bunch of bloat on it.

* big update

* boing

* ItemToggle + slots stuff (space-wizards#31312)

* ItemToggle + slots stuff

- Add component for itemslot locks to match LockComponent (surprised this didn't exist).
- Add thing for pointlight to match itemtoggle. In future should be used for PDAs and stuff but need to fix some other stuff first.

* Also this

* grill

* Run actions on press (space-wizards#31191)

I know UI generallys want to do stuff on key-up not key-down. With that being said the delay on release for these is noticeable.
e.g.
ActivateInWorld / UseInHand / any in-world interactions are on-press. This is especially noticeable if you have the same event on action + verb.

* Automatic changelog update

* Action stuff (space-wizards#31305)

* Action stuff

- Cleanup some event stuff
- Avoid dirtying entity unnecessarily
- Add ActionGrant as an easy way to apply / remove actions via compregistry.

* Fix merge

* Update submodule to 231.0.0 (space-wizards#31430)

* Weather fix (space-wizards#30857)

* weather fix

* localize errors

* ContainerComp fix (space-wizards#31434)

Forgot to push these ones on the branch.

* togglelight updates (space-wizards#31435)

Missed in the green checkmark sea

* Increase (SUPER)PACMAN ramp rate/tolerance (space-wizards#31403)

All PACMANs used to use the same ramping parameters, this meant a SUPERPACMAN (50 kW) took literally a 100 seconds to get up to its full output level. Ouch.

PACMAN has been raised to 5000 W/s with 1500 W tolerance, SUPERPACMAN to 7500 W/s with 2500 W tolerance

* Automatic changelog update

* Make space scanning T1 technology (space-wizards#31321)

make space scanning and mass scanner t1 tech

* Automatic changelog update

* Add a bool to disable buckling on InteractHand (space-wizards#30001)

* Automatic changelog update

* fix(FieldGenerators): Don't show nonsense popup (space-wizards#30469)

* .

* bagel update (space-wizards#31440)

* bagel update

* fixgridatmos

* qm office

* sci cam fix

* jesus christ so many routers

* remove invalids

* Fix-Resprite emote icons (space-wizards#31447)

* Fix-Resprite emote icons

* change scream

* Moff cooking. Part one. (space-wizards#30668)

* yml part

* guidebook

* commit

* some fixes

* a little

* change

* Automatic changelog update

* Cog update (space-wizards#31458)

made disposals less bad

* Add BUI ctor tests (space-wizards#31463)

5 lines of eaten iocmanager.injectdependencies led to this.

* Predict EmitSoundOnUIOpen (space-wizards#31464)

* Predict EmitSoundOnUIOpen

BUI prediction led to this moment.

* unforky

* Bots now make sound when they speak (space-wizards#31471)

fixes 31454

* Automatic changelog update

* Change the science radio channel color (space-wizards#31319)

* Change the science radio channel color

* This one looks better

* Automatic changelog update

* Move OnGhostAttempt to GhostSystem (space-wizards#31445)

* Move OnGhostAttempt to GhostSystem

* Remove unused dependencies and sort them

* Fix energy sword visuals (space-wizards#31478)

* Automatic changelog update

* Replace obsolete code in shuttle systems. (space-wizards#31408)

* Format DockingSystem.Shuttle

* arrivals system

* docking system

* shuttle console system

* emergency shuttle system

* shuttle system

* thruster system

* Fix compile error

---------

Co-authored-by: Pieter-Jan Briers <pieterjan.briers+git@gmail.com>

* Replaces small fans on most shuttles with directional fans. (space-wizards#31495)

* Automatic changelog update

* Replace obsolete functions in NPC systems (space-wizards#31448)

* Make guidebook remember where you left off (space-wizards#31375)

* Guidebook tracks last read entry

* Persistent guidebook fixes

* Persistent guidebook requested changes

* Update Content.Client/UserInterface/Systems/Guidebook/GuidebookUIController.cs

---------

Co-authored-by: Pieter-Jan Briers <pieterjan.briers@gmail.com>

* Automatic changelog update

* Remove double-iteration from the mime wall code (space-wizards#31420)

* Remove double-iteration from the mime wall code

* Update

* Update

* fix method OnEntityEnter in DamageContactsSystem (space-wizards#31494)

fix

Co-authored-by: Dimastra <dimastra@users.noreply.github.com>

* Automatic changelog update

* Make Gas Miners indestructable, anchorable, and pullable. (space-wizards#31370)

* Make miner indestructable, and pullable.

* Miners can't be unanchored. Only anchored.

---------

Co-authored-by: JIPDawg <JIPDawg93@gmail.com>

* Automatic changelog update

* bagel update (space-wizards#31502)

* Minor fixes to character profile editor save/reset buttons (space-wizards#31505)

Merge SetDirty() with preview reload

People were forgetting to SetDirty() when changing a property; move SetDirty()
into preview reloading, since if the preview is being reloaded, some property
has definitely changed anyway.

Co-authored-by: Eoin Mcloughlin <helloworld@eoinrul.es>

* Centcom & FTLDestination cleanup (space-wizards#30226)

* centcomm name and ftlcomp

* networking microopstimization

* go sleep.

* map names and arrivals

* Fix swapped around Safety Moth poster graphics (space-wizards#31507)

* Automatic changelog update

* Mark explosives as a contraband (space-wizards#31508)

* Automatic changelog update

* Mark the syndicate raid helmet as a Syndicate contraband (space-wizards#31512)

* Automatic changelog update

* Add title to multitool door-access-configuration window (space-wizards#31504)

Fixes space-wizards#29923.

Co-authored-by: Eoin Mcloughlin <helloworld@eoinrul.es>

* Restrict the explorer gas mask to cargo (space-wizards#31514)

* Automatic changelog update

* Fix stray pixel in officer beersky barsign (space-wizards#31517)

* Scale text in admin player overlay (space-wizards#31503)

* Scale text in admin player overlay

Fixes space-wizards#30040

* Feedback from PR - get UI scale through root window

---------

Co-authored-by: Eoin Mcloughlin <helloworld@eoinrul.es>

* New Health Analyzer UI (space-wizards#30834)

* WIP: first prototype

* Change text slightly

* Allow names to wrap

* Add label for the scan mode

* Remove ugly text

* Readd bleeding message

* Update code

* Allow for the Health Analyzer UI to grow vertically

* Automatic changelog update

* Disable Arrivals message for Cryosleep (space-wizards#30888)

* Disable arrivals message for cryosleep late arrivals

* Provide silent to PlayerSpawnCompleteEvent

* Fix typo

* Move message to event and into arrivals system

* Automatic changelog update

* Remove glibc from devshell (space-wizards#28842)

* Automated whitelists (space-wizards#23985)

* Beginnings of making the breadmemes jobs easier

* stuff

* stuff pt. 2

* Stuff pt.3

* Stuff I forgot last time

* Basic whitelist

Only people that are added to the whitelist with the addwhitelist command will be able to join. I call this the "legacy" whitelist

* Remove always deny condition in favor of just breaking if playtime check fails

* Change default whitelist

Default whitelist is now the "legacy" whitelist.

* localization

* Admin check

* minor spelling change

* Fix build

* Whitelist message

* Fix vars not being datafield and spelling mistakes

* Minor spelling mistake

* Change config for salamander

* Reviews and stuff

* Add summaries

* Fix whitelists

* Forgot to add a datafield

* Fixing stuff I guess

* Reuse admin remarks to reduce load when connecting.

* Update log messages to be verbose instead of debug

* Reviews

* whoops

* Explain a bit more how whitelist checking works

* Apply CE's review

* Append Membership to Blacklist and Whitelist conditions

* Fix review comments

* Uncapitalize playerConnectionWhitelist, add to ignored client prototypes

* Make note count field work

* Fix cvar for thingy

---------

Co-authored-by: Pieter-Jan Briers <pieterjan.briers+git@gmail.com>

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: PJBot <pieterjan.briers+bot@gmail.com>
Co-authored-by: Mervill <mervills.email@gmail.com>
Co-authored-by: PursuitInAshes <pursuitinashes@gmail.com>
Co-authored-by: eoineoineoin <github@eoinrul.es>
Co-authored-by: Eoin Mcloughlin <helloworld@eoinrul.es>
Co-authored-by: Pieter-Jan Briers <pieterjan.briers+git@gmail.com>
Co-authored-by: metalgearsloth <31366439+metalgearsloth@users.noreply.github.com>
Co-authored-by: themias <89101928+themias@users.noreply.github.com>
Co-authored-by: IProduceWidgets <107586145+IProduceWidgets@users.noreply.github.com>
Co-authored-by: Emisse <99158783+Emisse@users.noreply.github.com>
Co-authored-by: PopGamer46 <yt1popgamer@gmail.com>
Co-authored-by: ArtisticRoomba <145879011+ArtisticRoomba@users.noreply.github.com>
Co-authored-by: Nemanja <98561806+EmoGarbage404@users.noreply.github.com>
Co-authored-by: deltanedas <39013340+deltanedas@users.noreply.github.com>
Co-authored-by: Ed <96445749+TheShuEd@users.noreply.github.com>
Co-authored-by: Alzore <140123969+Blackern5000@users.noreply.github.com>
Co-authored-by: ShadowCommander <10494922+ShadowCommander@users.noreply.github.com>
Co-authored-by: Brandon Hu <103440971+Brandon-Huu@users.noreply.github.com>
Co-authored-by: lzk <124214523+lzk228@users.noreply.github.com>
Co-authored-by: Spessmann <156740760+Spessmann@users.noreply.github.com>
Co-authored-by: Moomoobeef <62638182+Moomoobeef@users.noreply.github.com>
Co-authored-by: Winkarst <74284083+Winkarst-cpu@users.noreply.github.com>
Co-authored-by: slarticodefast <161409025+slarticodefast@users.noreply.github.com>
Co-authored-by: QueerNB <176353696+QueerNB@users.noreply.github.com>
Co-authored-by: 12rabbits <53499656+12rabbits@users.noreply.github.com>
Co-authored-by: Pieter-Jan Briers <pieterjan.briers@gmail.com>
Co-authored-by: Dimastra <65184747+Dimastra@users.noreply.github.com>
Co-authored-by: Dimastra <dimastra@users.noreply.github.com>
Co-authored-by: JIPDawg <51352440+JIPDawg@users.noreply.github.com>
Co-authored-by: JIPDawg <JIPDawg93@gmail.com>
Co-authored-by: Saphire Lattice <lattice@saphi.re>
Co-authored-by: Thomas <87614336+Aeshus@users.noreply.github.com>
Co-authored-by: stellar-novas <stellar_novas@riseup.net>
Co-authored-by: Simon <63975668+Simyon264@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Changes: Map Changes: Might require knowledge of mapping. Changes: No C# Changes: Requires no C# knowledge to review or fix this item.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@QueerNB @Emisse