Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clean up random lathe recipes #31525

Merged
merged 6 commits into from
Dec 6, 2024
Merged

clean up random lathe recipes #31525

merged 6 commits into from
Dec 6, 2024

Conversation

deltanedas
Copy link
Contributor

About the PR

everything else
no user facing changes

requires #31515

Requirements

  • I have read and I am following the Pull Request Guidelines. I understand that not doing so may get my pr closed at maintainer’s discretion
  • I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Breaking changes

no

Changelog
no cl no fun

@github-actions github-actions bot added the Changes: No C# Changes: Requires no C# knowledge to review or fix this item. label Aug 27, 2024
@deltanedas deltanedas marked this pull request as ready for review August 31, 2024 02:15
@github-actions github-actions bot added the S: Merge Conflict Status: Needs to resolve merge conflicts before it can be accepted label Nov 2, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 2, 2024

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot removed the S: Merge Conflict Status: Needs to resolve merge conflicts before it can be accepted label Nov 2, 2024
@SlamBamActionman SlamBamActionman added the S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. label Nov 14, 2024
@github-actions GitHub Actions
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot added the S: Merge Conflict Status: Needs to resolve merge conflicts before it can be accepted label Nov 18, 2024
@eoineoineoin eoineoineoin added P3: Standard Priority: Default priority for repository items. T: Cleanup Type: Code clean-up, without being a full refactor or feature D3: Low Difficulty: Some codebase knowledge required. S: Needs Review Status: Requires additional reviews before being fully accepted A: Core Tech Area: Underlying core tech for the game and the Github repository. P2: Raised Priority: Item has a raised priority, indicating it might get increased maintainer attention. and removed S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. P3: Standard Priority: Default priority for repository items. labels Nov 20, 2024
@github-actions GitHub Actions
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@slarticodefast
Copy link
Member

When you fix the merge conflict, give me a ping and I will review this. Should be quick and easy.

@deltanedas
Copy link
Contributor Author

@slarticodefast ping

@github-actions github-actions bot added size/L Denotes a PR that changes 1000-4999 lines. and removed S: Merge Conflict Status: Needs to resolve merge conflicts before it can be accepted labels Dec 1, 2024
slarticodefast
slarticodefast approved these changes Dec 1, 2024
View reviewed changes
Copy link
Member

@slarticodefast slarticodefast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks for the cleanup!

@slarticodefast slarticodefast added S: Approved Status: Reviewed and approved by at least one maintainer; a PR may require another approval. and removed S: Needs Review Status: Requires additional reviews before being fully accepted labels Dec 1, 2024
@slarticodefast slarticodefast self-assigned this Dec 1, 2024
@VasilisThePikachu VasilisThePikachu merged commit 3300ff2 into space-wizards:master Dec 6, 2024
12 checks passed
@deltanedas deltanedas deleted the wildcard-recipe-ops branch December 6, 2024 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Aeshus Aeshus Aeshus left review comments

@slarticodefast slarticodefast slarticodefast approved these changes

@VasilisThePikachu VasilisThePikachu VasilisThePikachu approved these changes

Assignees

@slarticodefast slarticodefast

Labels
A: Core Tech Area: Underlying core tech for the game and the Github repository. Changes: No C# Changes: Requires no C# knowledge to review or fix this item. D3: Low Difficulty: Some codebase knowledge required. Merge Conflict P2: Raised Priority: Item has a raised priority, indicating it might get increased maintainer attention. S: Approved Status: Reviewed and approved by at least one maintainer; a PR may require another approval. size/L Denotes a PR that changes 1000-4999 lines. T: Cleanup Type: Code clean-up, without being a full refactor or feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@deltanedas @slarticodefast @VasilisThePikachu @Aeshus @eoineoineoin @SlamBamActionman