Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added many old ion lawsets for borgs and AI. #31664

Merged

Conversation

ScarKy0
Copy link
Contributor

@ScarKy0 ScarKy0 commented Aug 31, 2024

About the PR

Added a lot of ss13 lawsets as possible ion laws and AI circuit boards.

Why / Balance

Thought it would be funny to have more chaotic laws for cyborgs to be able to get.

Technical details

Added a lot of circuit boards, added new silicon laws, few of which can be rolled from ion storms.
Only .yml changes.

Media

image

Requirements

  • I have read and I am following the Pull Request Guidelines. I understand that not doing so may get my pr closed at maintainer’s discretion
  • I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Breaking changes

Changelog

🆑

  • add: Plenty of old silicon laws can now be rolled as ion laws.

…, Overlord, Dungeon Master, Artist, Antimov and Nutimov lawsets/
@ScarKy0 ScarKy0 requested a review from DrSmugleaf as a code owner August 31, 2024 01:22
@github-actions github-actions bot added Changes: No C# Changes: Requires no C# knowledge to review or fix this item. S: Needs Review Status: Requires additional reviews before being fully accepted labels Aug 31, 2024
@slarticodefast slarticodefast added the S: Undergoing Maintainer Discussion Status: Currently going through an extended discussion amongst maintainers, as per procedure. label Aug 31, 2024
@Everturning
Copy link

Can you make a normal crewsimov one for the ai that occasionally gets replaced with one of the others? Is that within scope?

@muburu
Copy link
Contributor

muburu commented Aug 31, 2024

antimov is hilarious i hope these get added

@ScarKy0
Copy link
Contributor Author

ScarKy0 commented Aug 31, 2024

Can you make a normal crewsimov one for the ai that occasionally gets replaced with one of the others? Is that within scope?

Thats something that someone else would need to add, I just simply added the laws to the code and made them possible to roll via ion laws

@nymhole
Copy link

nymhole commented Aug 31, 2024

i feel like we brushed past the part about ai circuit boards, the laws can be stored on circuit boards?

@ScarKy0
Copy link
Contributor Author

ScarKy0 commented Aug 31, 2024

i feel like we brushed past the part about ai circuit boards, the laws can be stored on circuit boards?

Currently there are circuit boards that cannot be obtained in a way other than the admin menu (unless they can and im not aware).
They can be inserted into the AI Upload Console to update the laws of the AI into whatever is on the board.
Currently in game theres NT, Corporate and Crewsimov, I just thought itd be fun to add those for the new lawsets I added in case someone makes them loot in maints or something, or for when they eventually become craftable

@AverageNotDoingAnythingEnjoyer
Copy link
Contributor

AverageNotDoingAnythingEnjoyer commented Aug 31, 2024

Currently in game theres NT, Corporate and Crewsimov

Wow, that's new

@ScarKy0
Copy link
Contributor Author

ScarKy0 commented Aug 31, 2024

Wow, that's new

Was added at the same time AI, its just that these items cannot be found unless an admin spawns them in

@perryprog
Copy link
Contributor

Am I missing something or is rolling Antimov just an instant “I gotta go singuloose”?

@ScarKy0
Copy link
Contributor Author

ScarKy0 commented Sep 1, 2024

Am I missing something or is rolling Antimov just an instant “I gotta go singuloose”?

It believe that would break the mass destruction rule, but im unsure how it works for borgs.
If anything can add a law 1 saying that its just the crew that needs destruction and not the station

@perryprog
Copy link
Contributor

Silicon laws bypass roleplay roles if you’re referring to RP rule 9.

@ScarKy0
Copy link
Contributor Author

ScarKy0 commented Sep 1, 2024

Silicon laws bypass roleplay roles if you’re referring to RP rule 9.

Oh yeah I just double checked, in that case I think it would be fine if you had a law 1 that says you have to avoid damaging the station

@nymhole
Copy link

nymhole commented Sep 1, 2024

antimov says nothing about being elaborate. i suppose if it is within reason then antimov would mean singuloose now, but the borg would also go on a manual killing spree, and then just kill itself. this would also affect syndicate borgs to kill all syndicates. antimov is simply amazing, even if it means borg looses tesla., maybe antimov should replace one at a time though?

@ScarKy0
Copy link
Contributor Author

ScarKy0 commented Sep 1, 2024

antimov says nothing about being elaborate. i suppose if it is within reason then antimov would mean singuloose now, but the borg would also go on a manual killing spree, and then just kill itself. this would also affect syndicate borgs to kill all syndicates. antimov is simply amazing, even if it means borg looses tesla., maybe antimov should replace one at a time though?

Replacing one at a time is not something i can do, but we also must remember that antimov is extremely low chance to roll as a lawset, especially since theres so many now, or will be if this gets merged

@nymhole
Copy link

nymhole commented Sep 1, 2024

sounds just fine, i think borgs need more chances to turn evil anyways.

@ScarKy0
Copy link
Contributor Author

ScarKy0 commented Sep 1, 2024

sounds just fine, i think borgs need more chances to turn evil anyways.

I think borgs already can turn "evil" plenty of time, especially if they know someone is a syndie they can just follow and help them as long as it doesnt break their laws
But I agree borgs need a lil more chaos

@nymhole
Copy link

nymhole commented Sep 1, 2024

its against the rules to knowingly allow yourself to be subverted by a syndicate, "you cannot request or allow a law change". i also really think that robotics should to be reworked.

@ScarKy0
Copy link
Contributor Author

ScarKy0 commented Sep 2, 2024

its against the rules to knowingly allow yourself to be subverted by a syndicate, "you cannot request or allow a law change"

I didnt mean get emagged, i meant that if you, as a borg, are aware someone uses you for evil you can literally just help them out more as long as youre not asked to hurt anyone

Copy link
Member

@UbaserB UbaserB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly good, just some wording issues.

Resources/Locale/en-US/station-laws/laws.ftl Outdated Show resolved Hide resolved
Resources/Locale/en-US/station-laws/laws.ftl Outdated Show resolved Hide resolved
Resources/Prototypes/silicon-laws.yml Outdated Show resolved Hide resolved
@UbaserB UbaserB added S: Awaiting Changes Status: Changes are required before another review can happen and removed S: Needs Review Status: Requires additional reviews before being fully accepted labels Sep 3, 2024
@ScarKy0 ScarKy0 requested a review from UbaserB September 3, 2024 08:54
@github-actions github-actions bot added S: Needs Review Status: Requires additional reviews before being fully accepted and removed S: Awaiting Changes Status: Changes are required before another review can happen labels Sep 3, 2024
@ScarKy0 ScarKy0 requested a review from UbaserB September 3, 2024 09:33
@UbaserB UbaserB merged commit 7832436 into space-wizards:master Sep 3, 2024
12 checks passed
@UbaserB UbaserB removed the S: Undergoing Maintainer Discussion Status: Currently going through an extended discussion amongst maintainers, as per procedure. label Sep 3, 2024
@Psychpsyo Psychpsyo mentioned this pull request Sep 5, 2024
2 tasks
@ScarKy0 ScarKy0 deleted the add-more-ion-law-rulesets-for-borgs branch September 5, 2024 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: No C# Changes: Requires no C# knowledge to review or fix this item. S: Needs Review Status: Requires additional reviews before being fully accepted
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants