Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Devmap crew monitor fix #31677

Merged
merged 1 commit into from
Sep 2, 2024
Merged

Devmap crew monitor fix #31677

merged 1 commit into from
Sep 2, 2024

Conversation

Errant-4
Copy link
Member

@Errant-4 Errant-4 commented Aug 31, 2024

About the PR

Crew Monitor Servers on Dev now work
Replacement crew monitor servers (on any map) now work

Why / Balance

Fixes #29787
Fixes #31657

Technical details

Crew Monitors do not auto-connect to the device network when spawned, because only one of them must be active on a station to make sure every suit sensor is connecting to the same server. When a suit sensor detects that it is not connected to a server, it starts an attempt to connect to or activate one.
On live maps, this check finds the Crew Monitor Server, finds it to be unavailable (possibly due to power not being available yet? apparently the other maps are saved with the crew monitor having those variables set to False. Mapping trickery or something. Anyway, my fix makes them work regardless of how they were saved), disconnects it and reports failure. A few seconds later the check is triggered again and finds the server to be Available this time so it connects, which gives the server a random Address.

However, on the Devmap (or when trying to spawn a new crew monitor server on ANY map during the round), the server will immediately report as active and available. So the game just takes it's Address, which is unfortunately the default empty string. The empty address is given to the suit sensor system which either ignores it or tries to use it and gets no response. Either way, it will check for crew monitor servers again a few seconds later, getting the empty Address again. And this repeats until the end of time.

An Empty String for Address now also treated as a server failure, triggering a reconnect and giving it a random address.

Requirements

  • I have read and I am following the Pull Request Guidelines. I understand that not doing so may get my pr closed at maintainer’s discretion
  • I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Changelog
🆑 Errant

  • fix: Replacement Crew Monitor Servers, as well as the Crew Monitor Server on the dev map, now work properly.

@Emisse Emisse merged commit 265feeb into space-wizards:master Sep 2, 2024
12 checks passed
@Errant-4 Errant-4 deleted the devcrewmon branch September 4, 2024 05:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Crew Monitoring Server missing comps when mapped Devmap crew monitor broken
2 participants