Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the PR
Crew Monitor Servers on Dev now work
Replacement crew monitor servers (on any map) now work
Why / Balance
Fixes #29787
Fixes #31657
Technical details
Crew Monitors do not auto-connect to the device network when spawned, because only one of them must be active on a station to make sure every suit sensor is connecting to the same server. When a suit sensor detects that it is not connected to a server, it starts an attempt to connect to or activate one.
On live maps, this check finds the Crew Monitor Server, finds it to be unavailable (
possibly due to power not being available yet?apparently the other maps are saved with the crew monitor having those variables set to False. Mapping trickery or something. Anyway, my fix makes them work regardless of how they were saved), disconnects it and reports failure. A few seconds later the check is triggered again and finds the server to be Available this time so it connects, which gives the server a random Address.However, on the Devmap (or when trying to spawn a new crew monitor server on ANY map during the round), the server will immediately report as active and available. So the game just takes it's Address, which is unfortunately the default empty string. The empty address is given to the suit sensor system which either ignores it or tries to use it and gets no response. Either way, it will check for crew monitor servers again a few seconds later, getting the empty Address again. And this repeats until the end of time.
An Empty String for Address now also treated as a server failure, triggering a reconnect and giving it a random address.
Requirements
Changelog
🆑 Errant