Ninja throwing star ability fix #31684
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
godisdeadLOL
force-pushed
the
ninja-star-fix
branch
from
a2cb5d2 to
a96be94
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the PR
Fixed the bug when activating ninja throwing star ability wouldn't spawn a throwing star.
Why / Balance
fixes #31594
Technical details
Throwing star ability has reference to current battery which only changes on
NinjaBatteryChangedEventraised.NinjaBatteryChangedEventis only called when ninja gloves are activated or suit battery is upgraded which means there was no way to get reference to starting battery. RaisingNinjaBatteryChangedEventon ninja suit equip fixes the problem.Also, raise
NinjaBatteryChangedEventfor both suit and ninja inEnableGlovesbecauseNinjaBatteryChangedEventdescription says so.Media
lol.mp4
Requirements
Breaking changes
Changelog
🆑 yuitop